[PR #1594] [MERGED] Additional ACL response attributes #1639

New issue

Closed

opened 2026-03-03 12:35:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:35:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1594
Author: @manuteleco
Created: 5/5/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @fsouza

Base: main ← Head: additional_acl_response_attributes

📝 Commits (1)

052cc15 Additional ACL response attributes

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 fakestorage/object_test.go (+2 -2)
📝 fakestorage/response.go (+2 -0)

📄 Description

Include these attributes in the JSON response for access control lists.

etag
kind

Some client libraries expect them to be present, and fail to deserialize the response otherwise.

The value for kind matches what the real GCS API returns. We don't care too much about the ETag value at this stage, so we just picked a valid constant.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1594 **Author:** [@manuteleco](https://github.com/manuteleco) **Created:** 5/5/2024 **Status:** ✅ Merged **Merged:** 5/7/2024 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `additional_acl_response_attributes` --- ### 📝 Commits (1) - [`052cc15`](https://github.com/fsouza/fake-gcs-server/commit/052cc15dd18e062607715bb5f1d32fb2ef03baa0) Additional ACL response attributes ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object_test.go` (+2 -2) 📝 `fakestorage/response.go` (+2 -0) </details> ### 📄 Description Include these attributes in the JSON response for access control lists. * `etag` * `kind` Some [client libraries][1] expect them to be present, and fail to deserialize the response otherwise. The value for `kind` matches what the real GCS API returns. We don't care too much about the ETag value at this stage, so we just picked a valid constant. [1]: https://crates.io/crates/google-cloud-storage --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>