[PR #1529] [MERGED] Fix brittle test #1579

New issue

Closed

opened 2026-03-03 12:35:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:35:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1529
Author: @manuteleco
Created: 3/10/2024
Status: ✅ Merged
Merged: 3/13/2024
Merged by: @fsouza

Base: main ← Head: fix_brittle_test

📝 Commits (1)

840ad2f Fix brittle test

📊 Changes

1 file changed (+16 additions, -11 deletions)

View changed files

📝 internal/backend/backend_test.go (+16 -11)

📄 Description

This test was failing sometimes due to a mismatch in clocks between Go and the filesystem, with messages like this one:

listed bucket has unexpected creation time. Expected between test
start time 2024-03-10 06:58:36.004471224 +0000 UTC m=+0.048304750
   and now 2024-03-10 06:58:36.006076153 +0000 UTC m=+0.049909699
   actual: 2024-03-10 06:58:35.999266041 +0000 UTC

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1529 **Author:** [@manuteleco](https://github.com/manuteleco) **Created:** 3/10/2024 **Status:** ✅ Merged **Merged:** 3/13/2024 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `fix_brittle_test` --- ### 📝 Commits (1) - [`840ad2f`](https://github.com/fsouza/fake-gcs-server/commit/840ad2fe4663b6b72e2a6a2f09e897d343c4c676) Fix brittle test ### 📊 Changes **1 file changed** (+16 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `internal/backend/backend_test.go` (+16 -11) </details> ### 📄 Description This test was failing sometimes due to a mismatch in clocks between Go and the filesystem, with messages like this one: ``` listed bucket has unexpected creation time. Expected between test start time 2024-03-10 06:58:36.004471224 +0000 UTC m=+0.048304750 and now 2024-03-10 06:58:36.006076153 +0000 UTC m=+0.049909699 actual: 2024-03-10 06:58:35.999266041 +0000 UTC ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>