[PR #1520] [MERGED] Support the projection parameter in getObject #1569

Closed
opened 2026-03-03 12:35:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1520
Author: @manuteleco
Created: 3/8/2024
Status: Merged
Merged: 3/18/2024
Merged by: @fsouza

Base: mainHead: support_projection_in_getobject


📝 Commits (1)

  • bb21b0a Support the projection parameter in getObject

📊 Changes

3 files changed (+136 additions, -1 deletions)

View changed files

📝 fakestorage/object.go (+16 -1)
📝 fakestorage/object_test.go (+111 -0)
📝 fakestorage/response.go (+9 -0)

📄 Description

According to the behavior described in the official documentation. That is, ACL information should only be returned if projection=full is provided as GET parameter.

This behavior is not testeable using the Go GCS client, because it hardcodes the value full when performing the HTTP request (see implementation).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1520 **Author:** [@manuteleco](https://github.com/manuteleco) **Created:** 3/8/2024 **Status:** ✅ Merged **Merged:** 3/18/2024 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `support_projection_in_getobject` --- ### 📝 Commits (1) - [`bb21b0a`](https://github.com/fsouza/fake-gcs-server/commit/bb21b0a476b1466e133a1c4c9c7cd064a67847cf) Support the `projection` parameter in `getObject` ### 📊 Changes **3 files changed** (+136 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+16 -1) 📝 `fakestorage/object_test.go` (+111 -0) 📝 `fakestorage/response.go` (+9 -0) </details> ### 📄 Description According to the behavior described in the [official documentation][1]. That is, ACL information should only be returned if `projection=full` is provided as GET parameter. This behavior is not testeable using the Go GCS client, because it hardcodes the value `full` when performing the HTTP request (see [implementation][2]). [1]: https://cloud.google.com/storage/docs/json_api/v1/objects/get#parameters [2]: https://github.com/googleapis/google-cloud-go/blob/storage/v1.39.0/storage/http_client.go#L413 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:35:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#1569
No description provided.