[PR #1430] [MERGED] Fixed patchObject ignoring ContentType and ContentEncoding #1484

New issue

Closed

opened 2026-03-03 12:34:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:34:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1430
Author: @UnAfraid
Created: 12/15/2023
Status: ✅ Merged
Merged: 12/19/2023
Merged by: @fsouza

Base: main ← Head: bugfix/patch-content-type

📝 Commits (1)

6877db5 Fixed patchObject ignoring ContentType and ContentEncoding

📊 Changes

2 files changed (+10 additions, -5 deletions)

View changed files

📝 fakestorage/object.go (+7 -3)
📝 internal/grpc/server.go (+3 -2)

📄 Description

I was trying to update object's ContentType and noticed that only metadata was updated, but not the ContentType upon looking at the code i noticed that its ignored entirely.

Most likely fixes https://github.com/fsouza/fake-gcs-server/issues/273

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1430 **Author:** [@UnAfraid](https://github.com/UnAfraid) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `bugfix/patch-content-type` --- ### 📝 Commits (1) - [`6877db5`](https://github.com/fsouza/fake-gcs-server/commit/6877db54f34c330ad654f91b88530235e2272b86) Fixed patchObject ignoring ContentType and ContentEncoding ### 📊 Changes **2 files changed** (+10 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+7 -3) 📝 `internal/grpc/server.go` (+3 -2) </details> ### 📄 Description I was trying to update object's ContentType and noticed that only metadata was updated, but not the ContentType upon looking at the code i noticed that its ignored entirely. Most likely fixes https://github.com/fsouza/fake-gcs-server/issues/273 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>