[PR #1344] [MERGED] add missing etag header in download object response #1405

New issue

Closed

opened 2026-03-03 12:34:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:34:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1344
Author: @houqp
Created: 10/1/2023
Status: ✅ Merged
Merged: 10/1/2023
Merged by: @fsouza

Base: main ← Head: main

📝 Commits (1)

9f99703 add missing etag header in download object response

📊 Changes

2 files changed (+5 additions, -0 deletions)

View changed files

📝 fakestorage/object.go (+1 -0)
📝 fakestorage/object_test.go (+4 -0)

📄 Description

According to the official API spec, Etag header is required: https://cloud.google.com/storage/docs/xml-api/get-object-download

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1344 **Author:** [@houqp](https://github.com/houqp) **Created:** 10/1/2023 **Status:** ✅ Merged **Merged:** 10/1/2023 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`9f99703`](https://github.com/fsouza/fake-gcs-server/commit/9f99703fc5419021dd41eed1ab67dee6e7dff86f) add missing etag header in download object response ### 📊 Changes **2 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+1 -0) 📝 `fakestorage/object_test.go` (+4 -0) </details> ### 📄 Description According to the official API spec, Etag header is required: https://cloud.google.com/storage/docs/xml-api/get-object-download --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>