[PR #1272] [MERGED] Restore 4443 as default port for '-scheme http' as before PR #1215 #1346

Closed
opened 2026-03-03 12:34:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1272
Author: @raz-amir
Created: 8/1/2023
Status: Merged
Merged: 8/1/2023
Merged by: @fsouza

Base: mainHead: ramir_fix_http_default_port


📝 Commits (1)

  • e9b49b6 Restore 4443 as default port for '-scheme http' as before PR #1215

📊 Changes

2 files changed (+5 additions, -9 deletions)

View changed files

📝 internal/config/config.go (+3 -7)
📝 internal/config/config_test.go (+2 -2)

📄 Description

Fix breaking change caused by PR #1215:
Restore the default port that was used for -scheme http before the integration that PR


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1272 **Author:** [@raz-amir](https://github.com/raz-amir) **Created:** 8/1/2023 **Status:** ✅ Merged **Merged:** 8/1/2023 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `ramir_fix_http_default_port` --- ### 📝 Commits (1) - [`e9b49b6`](https://github.com/fsouza/fake-gcs-server/commit/e9b49b60eb52c8693570b428e2909b8d6197b326) Restore 4443 as default port for '-scheme http' as before PR #1215 ### 📊 Changes **2 files changed** (+5 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `internal/config/config.go` (+3 -7) 📝 `internal/config/config_test.go` (+2 -2) </details> ### 📄 Description Fix breaking change caused by PR #1215: Restore the default port that was used for `-scheme http` before the integration that PR --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:34:10 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#1346
No description provided.