[PR #1184] [MERGED] internal/config: always have an externalURL #1268

New issue

Closed

opened 2026-03-03 12:33:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:33:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1184
Author: @fsouza
Created: 5/27/2023
Status: ✅ Merged
Merged: 5/27/2023
Merged by: @fsouza

Base: main ← Head: always-have-externalURL

📝 Commits (1)

d2c9a5d internal/config: always have an externalURL

📊 Changes

2 files changed (+8 additions, -4 deletions)

View changed files

📝 internal/config/config.go (+7 -3)
📝 internal/config/config_test.go (+1 -1)

📄 Description

This is a regression introduced in #1159: when default parameters are used, the external URL would be empty, breaking resumable uploads.

Fixes #1166.
Fixes #1170.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1184 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 5/27/2023 **Status:** ✅ Merged **Merged:** 5/27/2023 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `always-have-externalURL` --- ### 📝 Commits (1) - [`d2c9a5d`](https://github.com/fsouza/fake-gcs-server/commit/d2c9a5da29c1646c87ad9fc0e122cb89ea57c57f) internal/config: always have an externalURL ### 📊 Changes **2 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/config/config.go` (+7 -3) 📝 `internal/config/config_test.go` (+1 -1) </details> ### 📄 Description This is a regression introduced in #1159: when default parameters are used, the external URL would be empty, breaking resumable uploads. Fixes #1166. Fixes #1170. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>