[PR #1167] [MERGED] Add bucket filter for notification events #1253

New issue

Closed

opened 2026-03-03 12:33:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:33:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1167
Author: @mccalltd
Created: 5/16/2023
Status: ✅ Merged
Merged: 5/27/2023
Merged by: @fsouza

Base: main ← Head: event-notification-bucket-filter

📝 Commits (1)

0d5ff48 Add bucket filter for notification events

📊 Changes

4 files changed (+51 additions, -0 deletions)

View changed files

📝 internal/config/config.go (+3 -0)
📝 internal/config/config_test.go (+2 -0)
📝 internal/notification/event.go (+8 -0)
📝 internal/notification/event_test.go (+38 -0)

📄 Description

Thanks for this project!

I found the current object level filter for bucket notifications insufficient for my usage.

This PR extends the notification event config to accept a bucket filter. I could change this to accept a CSV of bucket names instead, and would be happy to do so if you thought that would be better. Left it simple to start.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1167 **Author:** [@mccalltd](https://github.com/mccalltd) **Created:** 5/16/2023 **Status:** ✅ Merged **Merged:** 5/27/2023 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `event-notification-bucket-filter` --- ### 📝 Commits (1) - [`0d5ff48`](https://github.com/fsouza/fake-gcs-server/commit/0d5ff481665bf42bad8dda7e4f6a71d52563666d) Add bucket filter for notification events ### 📊 Changes **4 files changed** (+51 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/config/config.go` (+3 -0) 📝 `internal/config/config_test.go` (+2 -0) 📝 `internal/notification/event.go` (+8 -0) 📝 `internal/notification/event_test.go` (+38 -0) </details> ### 📄 Description Thanks for this project! I found the current object level filter for bucket notifications insufficient for my usage. This PR extends the notification event config to accept a bucket filter. I could change this to accept a CSV of bucket names instead, and would be happy to do so if you thought that would be better. Left it simple to start. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>