[PR #1159] [MERGED] Fix HTTPS #1246

New issue

Closed

opened 2026-03-03 12:33:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:33:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1159
Author: @fsouza
Created: 5/10/2023
Status: ✅ Merged
Merged: 5/10/2023
Merged by: @fsouza

Base: main ← Head: fix-https

📝 Commits (3)

343707f Make the grpc package internal
052428c Refactor how we handle gRPC multiplexing
effd073 Add example from README to CI

📊 Changes

10 files changed (+142 additions, -100 deletions)

View changed files

📝 .github/workflows/main.yml (+3 -0)
➕ ci/run-curl-example.sh (+10 -0)
📝 fakestorage/server.go (+44 -40)
📝 go.mod (+0 -1)
📝 go.sum (+0 -3)
📝 internal/config/config.go (+29 -28)
📝 internal/config/config_test.go (+12 -10)
📝 internal/grpc/server.go (+2 -3)
📝 internal/grpc/server_test.go (+0 -0)
📝 main.go (+42 -15)

📄 Description

Make sure the gRPC multiplexing works with HTTPS.

Fixes #1157.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1159 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 5/10/2023 **Status:** ✅ Merged **Merged:** 5/10/2023 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `fix-https` --- ### 📝 Commits (3) - [`343707f`](https://github.com/fsouza/fake-gcs-server/commit/343707fd3b5ea14a0b550a73922950e6e3595996) Make the grpc package internal - [`052428c`](https://github.com/fsouza/fake-gcs-server/commit/052428c9f05e794681eaa9cea4c9a73aed177676) Refactor how we handle gRPC multiplexing - [`effd073`](https://github.com/fsouza/fake-gcs-server/commit/effd0739dad5a367b590320004d426207d67bd6a) Add example from README to CI ### 📊 Changes **10 files changed** (+142 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/main.yml` (+3 -0) ➕ `ci/run-curl-example.sh` (+10 -0) 📝 `fakestorage/server.go` (+44 -40) 📝 `go.mod` (+0 -1) 📝 `go.sum` (+0 -3) 📝 `internal/config/config.go` (+29 -28) 📝 `internal/config/config_test.go` (+12 -10) 📝 `internal/grpc/server.go` (+2 -3) 📝 `internal/grpc/server_test.go` (+0 -0) 📝 `main.go` (+42 -15) </details> ### 📄 Description Make sure the gRPC multiplexing works with HTTPS. Fixes #1157. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>