[PR #1121] [MERGED] Fix directory being used during reseed #1208

New issue

Closed

opened 2026-03-03 12:33:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:33:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1121
Author: @eliasdaler
Created: 4/4/2023
Status: ✅ Merged
Merged: 4/6/2023
Merged by: @fsouza

Base: main ← Head: main

📝 Commits (1)

2515e19 Fix directory being used during reseed

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 fakestorage/server.go (+2 -2)
📝 internal/config/config.go (+1 -0)

📄 Description

Related to #1079.

"/data" directory was hard-coded previously, needed to use config's "Seed" instead.
E.g. when running it like this:
docker run -d -p 4444:4443 -v ~/test_data:/store fsouza/fake-gcs-server -data "/store"
the files were being loaded from "/data" and not from /store.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1121 **Author:** [@eliasdaler](https://github.com/eliasdaler) **Created:** 4/4/2023 **Status:** ✅ Merged **Merged:** 4/6/2023 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`2515e19`](https://github.com/fsouza/fake-gcs-server/commit/2515e19a135256a07eb4efa8f924951190d0cc47) Fix directory being used during reseed ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/server.go` (+2 -2) 📝 `internal/config/config.go` (+1 -0) </details> ### 📄 Description Related to #1079. "/data" directory was hard-coded previously, needed to use config's "Seed" instead. E.g. when running it like this: `docker run -d -p 4444:4443 -v ~/test_data:/store fsouza/fake-gcs-server -data "/store"` the files were being loaded from "/data" and not from `/store`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>