[PR #1112] [CLOSED] Fix/fix some directory issues #1205

New issue

Closed

opened 2026-03-03 12:33:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:33:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1112
Author: @mahmoudbahaa
Created: 3/30/2023
Status: ❌ Closed

Base: main ← Head: fix/fix-some-directory-issues

📝 Commits (5)

2a50d10 add updated field to bucket response and Model
f806aee use removeAll instead of remove when deleting a file/directory
726bf64 introduce rename function that is used in rewrite to rename directories properly
8271b29 better support directories in filesystem //TODO: do the same for memory
ca2f54f fix rewrite by remving rename and doing recursive copy instead as it should - WIP

📊 Changes

7 files changed (+188 additions, -31 deletions)

View changed files

📝 fakestorage/object.go (+11 -3)
📝 fakestorage/response.go (+2 -0)
📝 internal/backend/backend_test.go (+2 -2)
📝 internal/backend/bucket.go (+1 -0)
📝 internal/backend/fs.go (+96 -15)
📝 internal/backend/memory.go (+75 -11)
📝 internal/backend/storage.go (+1 -0)

📄 Description

add updated field to bucket response and Model
better support directories in filesystem //TODO: do the same for memory

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1112 **Author:** [@mahmoudbahaa](https://github.com/mahmoudbahaa) **Created:** 3/30/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/fix-some-directory-issues` --- ### 📝 Commits (5) - [`2a50d10`](https://github.com/fsouza/fake-gcs-server/commit/2a50d105d6a37a0884f9a4709b1dc39024dbc02a) add updated field to bucket response and Model - [`f806aee`](https://github.com/fsouza/fake-gcs-server/commit/f806aeea2c552ab9163f2cd0ffdf74bea991f56d) use removeAll instead of remove when deleting a file/directory - [`726bf64`](https://github.com/fsouza/fake-gcs-server/commit/726bf649aa5f6ed68d8a1779d3d96f23708e4427) introduce rename function that is used in rewrite to rename directories properly - [`8271b29`](https://github.com/fsouza/fake-gcs-server/commit/8271b29f232f8592d9e17b83e343560fff7e9dd8) better support directories in filesystem //TODO: do the same for memory - [`ca2f54f`](https://github.com/fsouza/fake-gcs-server/commit/ca2f54f0efbd9054ad8f174897c57411f36a9385) fix rewrite by remving rename and doing recursive copy instead as it should - WIP ### 📊 Changes **7 files changed** (+188 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+11 -3) 📝 `fakestorage/response.go` (+2 -0) 📝 `internal/backend/backend_test.go` (+2 -2) 📝 `internal/backend/bucket.go` (+1 -0) 📝 `internal/backend/fs.go` (+96 -15) 📝 `internal/backend/memory.go` (+75 -11) 📝 `internal/backend/storage.go` (+1 -0) </details> ### 📄 Description - add updated field to bucket response and Model - better support directories in filesystem //TODO: do the same for memory --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>