[PR #1049] [MERGED] Update UpdateObject function to handle more attributes #1146

Closed
opened 2026-03-03 12:33:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1049
Author: @RachitSharma2001
Created: 1/13/2023
Status: Merged
Merged: 1/25/2023
Merged by: @fsouza

Base: mainHead: update-object


📝 Commits (1)

  • ceee956 Update UpdateObject function to handle more attributes

📊 Changes

5 files changed (+91 additions, -16 deletions)

View changed files

📝 fakestorage/object.go (+26 -6)
📝 fakestorage/object_test.go (+53 -0)
📝 internal/backend/fs.go (+5 -4)
📝 internal/backend/memory.go (+6 -5)
📝 internal/backend/storage.go (+1 -1)

📄 Description

Builds off #1036

I noticed that there are currently no tests for UpdateObject. I would be open to adding one or a few if they are needed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1049 **Author:** [@RachitSharma2001](https://github.com/RachitSharma2001) **Created:** 1/13/2023 **Status:** ✅ Merged **Merged:** 1/25/2023 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `update-object` --- ### 📝 Commits (1) - [`ceee956`](https://github.com/fsouza/fake-gcs-server/commit/ceee956aedf81bcac334c395926206665f3f401e) Update UpdateObject function to handle more attributes ### 📊 Changes **5 files changed** (+91 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+26 -6) 📝 `fakestorage/object_test.go` (+53 -0) 📝 `internal/backend/fs.go` (+5 -4) 📝 `internal/backend/memory.go` (+6 -5) 📝 `internal/backend/storage.go` (+1 -1) </details> ### 📄 Description Builds off #1036 I noticed that there are currently no tests for `UpdateObject`. I would be open to adding one or a few if they are needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:33:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#1146
No description provided.