[PR #1022] [MERGED] Make resumable uploads work from browser with signed url #1123

New issue

Closed

opened 2026-03-03 12:33:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:33:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1022
Author: @jasonford
Created: 12/27/2022
Status: ✅ Merged
Merged: 12/28/2022
Merged by: @fsouza

Base: main ← Head: make-client-resumable-uploads-work

📝 Commits (3)

4b44e10 Expose location header for cors requests
6fa4712 Add missing Access-Control-Allow-Origin header for get request
1a563df Add Content-Range to allowed headers

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 fakestorage/object.go (+1 -0)
📝 fakestorage/server.go (+2 -1)

📄 Description

These headers are necessary to make browser originated signed url requests work.

I don't know go, and these edits likely should be handled at a different level/more comprehensively. Happy to modify and repush if you've got feedback. If not, this PR could be a good sketch for better updates to support browser based signed url requests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1022 **Author:** [@jasonford](https://github.com/jasonford) **Created:** 12/27/2022 **Status:** ✅ Merged **Merged:** 12/28/2022 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `make-client-resumable-uploads-work` --- ### 📝 Commits (3) - [`4b44e10`](https://github.com/fsouza/fake-gcs-server/commit/4b44e10714cf449a98af683132c67169fb931f6b) Expose location header for cors requests - [`6fa4712`](https://github.com/fsouza/fake-gcs-server/commit/6fa4712c095ab16982abcc5d1b7f86f0c8af6807) Add missing Access-Control-Allow-Origin header for get request - [`1a563df`](https://github.com/fsouza/fake-gcs-server/commit/1a563dfc69d62bc78f508ce5ffbd42e79b8ee365) Add Content-Range to allowed headers ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+1 -0) 📝 `fakestorage/server.go` (+2 -1) </details> ### 📄 Description These headers are necessary to make browser originated signed url requests work. I don't know go, and these edits likely should be handled at a different level/more comprehensively. Happy to modify and repush if you've got feedback. If not, this PR could be a good sketch for better updates to support browser based signed url requests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>