[GH-ISSUE #45] Add a dockerized server configuration #11

Closed
opened 2026-03-03 12:07:21 +03:00 by kerem · 4 comments
Owner

Originally created by @jwhitlock on GitHub (Jul 2, 2019).
Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/45

https://github.com/teone/gc-fake-storage provides a Dockerfile and related scripts to allow this code to be run as a server, so that it can be used outside of tests of Go code. This Docker image is published at https://hub.docker.com/r/matteoscandolo/gc-fake-storage.

It would be easier to improve and test this use case if the Docker configuration was part of this project instead. It could be easier to coordinate creating a new image when the library changes. Also, contributors could collaborate on language-specific clients, verified by integration tests.

There is no explicit license on https://github.com/teone/gc-fake-storage, which I believe means @teone has the copyright, which makes it incompatible with this project's BSD 2 license, copyright Francisco Souza. I believe the clearest way to merge the code is if @teone makes the initial PR, which makes it clear he's contributing under the license for this this project. After the initial merge of files, I'd be happy to make additional changes.

This was first discussed on closed PR https://github.com/fsouza/fake-gcs-server/pull/39#issuecomment-501852822

Originally created by @jwhitlock on GitHub (Jul 2, 2019). Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/45 https://github.com/teone/gc-fake-storage provides a ``Dockerfile`` and related scripts to allow this code to be run as a server, so that it can be used outside of tests of Go code. This Docker image is published at https://hub.docker.com/r/matteoscandolo/gc-fake-storage. It would be easier to improve and test this use case if the Docker configuration was part of this project instead. It could be easier to coordinate creating a new image when the library changes. Also, contributors could collaborate on language-specific clients, verified by integration tests. There is no explicit license on https://github.com/teone/gc-fake-storage, which I believe means @teone has the copyright, which makes it incompatible with this project's BSD 2 license, copyright Francisco Souza. I believe the clearest way to merge the code is if @teone makes the initial PR, which makes it clear he's contributing under the license for this this project. After the initial merge of files, I'd be happy to make additional changes. This was first discussed on closed PR https://github.com/fsouza/fake-gcs-server/pull/39#issuecomment-501852822
kerem closed this issue 2026-03-03 12:07:22 +03:00
Author
Owner

@fsouza commented on GitHub (Jul 12, 2019):

@jwhitlock I'm planning to give a shot at this next week. If we don't hear back from @teone, I can create a different main package under cmd/fake-gcs (or cmd/gcs-emulator, dunno).

<!-- gh-comment-id:510707677 --> @fsouza commented on GitHub (Jul 12, 2019): @jwhitlock I'm planning to give a shot at this next week. If we don't hear back from @teone, I can create a different main package under ``cmd/fake-gcs`` (or ``cmd/gcs-emulator``, dunno).
Author
Owner

@teone commented on GitHub (Jul 12, 2019):

Hi @fsouza and @jwhitlock https://github.com/jwhitlock,
I'll be more than happy to make a pull request!

I should be able to do it aome time next week

On Thu, Jul 11, 2019, 6:16 PM francisco notifications@github.com wrote:

@ https://github.com/jwhitlock I'm planning to give a shot at this next
week. If we don't hear back from @teone https://github.com/teone, I can
create a different main package under cmd/fake-gcs (or cmd/gcs-emulator,
dunno).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsouza/fake-gcs-server/issues/45?email_source=notifications&email_token=AA57K6UG2TD22YU6O435IYTP67LNTA5CNFSM4H45VOAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZYMPXI#issuecomment-510707677,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA57K6WOYR3YOGHG56KFHXTP67LNTANCNFSM4H45VOAA
.

<!-- gh-comment-id:510724552 --> @teone commented on GitHub (Jul 12, 2019): Hi @fsouza and @jwhitlock <https://github.com/jwhitlock>, I'll be more than happy to make a pull request! I should be able to do it aome time next week On Thu, Jul 11, 2019, 6:16 PM francisco <notifications@github.com> wrote: > @ <https://github.com/jwhitlock> I'm planning to give a shot at this next > week. If we don't hear back from @teone <https://github.com/teone>, I can > create a different main package under cmd/fake-gcs (or cmd/gcs-emulator, > dunno). > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/fsouza/fake-gcs-server/issues/45?email_source=notifications&email_token=AA57K6UG2TD22YU6O435IYTP67LNTA5CNFSM4H45VOAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZYMPXI#issuecomment-510707677>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA57K6WOYR3YOGHG56KFHXTP67LNTANCNFSM4H45VOAA> > . >
Author
Owner

@fsouza commented on GitHub (Jul 12, 2019):

Nice! Will wait then :D

<!-- gh-comment-id:510732645 --> @fsouza commented on GitHub (Jul 12, 2019): Nice! Will wait then :D
Author
Owner

@fsouza commented on GitHub (Jul 16, 2019):

@jwhitlock @teone please take a look at #46.

<!-- gh-comment-id:511994127 --> @fsouza commented on GitHub (Jul 16, 2019): @jwhitlock @teone please take a look at #46.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#11
No description provided.