[PR #913] [MERGED] backend/fs: place temporary file in the destination directory #1029

Closed
opened 2026-03-03 12:32:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/913
Author: @fsouza
Created: 9/5/2022
Status: Merged
Merged: 9/5/2022
Merged by: @fsouza

Base: mainHead: fix-tmp-dir


📝 Commits (1)

  • 232c89d backend/fs: place temporary file in the destination directory

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 internal/backend/fs.go (+1 -1)

📄 Description

This should guarantee that we can rename it. Well, unless we run into
some weird underlying filesystem that doesn't support renaming, but
hopefully we don't have to cross that bridge.

Closes #912.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/913 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 9/5/2022 **Status:** ✅ Merged **Merged:** 9/5/2022 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `fix-tmp-dir` --- ### 📝 Commits (1) - [`232c89d`](https://github.com/fsouza/fake-gcs-server/commit/232c89da81ba672291395a2d003e97bad829d341) backend/fs: place temporary file in the destination directory ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/backend/fs.go` (+1 -1) </details> ### 📄 Description This should guarantee that we can rename it. Well, unless we run into some weird underlying filesystem that doesn't support renaming, but hopefully we don't have to cross that bridge. Closes #912. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:32:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#1029
No description provided.