[PR #2] [MERGED] Some (small) cosmetics #3

Closed
opened 2026-02-27 23:03:21 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sixdimensionalarray/esxidown/pull/2
Author: @fbartels
Created: 12/30/2013
Status: Merged
Merged: 1/5/2014
Merged by: @sixdimensionalarray

Base: masterHead: master


📝 Commits (6)

  • eb26fbd wait only 10 secounds each try, but try 20 times. (reduces wait time)
  • cd6f2b6 Put host into maintenance mode first thing, to prevent other vms from starting.
  • d7287a2 of course don't wait for the maintenance mode to be finished
  • 8ad31c6 change query to get ids of the machines to support annotations on machines
  • ad57f57 don't shut down machines that are already suspended
  • 3e71e7c changed the wrong line

📊 Changes

1 file changed (+10 additions, -10 deletions)

View changed files

📝 esxidown.sh (+10 -10)

📄 Description

Hi,

I found your script as I was searching for an easy way to power down my testing server in the evening. To fit my needs I changed some small things namely:

  • set maintenance mode first
    just to prevent other machines from powering up, while I want to power down.
  • reduced wait time and higher the times a shutdown is tried
    also the script would always wait a full minute even if a machine immediately powers down.
  • changed query for vmid
    I have some annotations in my machines, with the old query he also wanted to power down my annotations
  • ignore machines that are already in suspended mode
    do what it says.

I hope you find this helpful as well.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sixdimensionalarray/esxidown/pull/2 **Author:** [@fbartels](https://github.com/fbartels) **Created:** 12/30/2013 **Status:** ✅ Merged **Merged:** 1/5/2014 **Merged by:** [@sixdimensionalarray](https://github.com/sixdimensionalarray) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`eb26fbd`](https://github.com/sixdimensionalarray/esxidown/commit/eb26fbdfd11476502e92c687d2ba133b629f6553) wait only 10 secounds each try, but try 20 times. (reduces wait time) - [`cd6f2b6`](https://github.com/sixdimensionalarray/esxidown/commit/cd6f2b61a5b71967874c9f3f67f2bfa8a893cbff) Put host into maintenance mode first thing, to prevent other vms from starting. - [`d7287a2`](https://github.com/sixdimensionalarray/esxidown/commit/d7287a2f91ae9c4775e8a2c98334f4a17ff6328e) of course don't wait for the maintenance mode to be finished - [`8ad31c6`](https://github.com/sixdimensionalarray/esxidown/commit/8ad31c691a65229bb2bf4b27310378b579f4ae4a) change query to get ids of the machines to support annotations on machines - [`ad57f57`](https://github.com/sixdimensionalarray/esxidown/commit/ad57f570384eaa2635bd704e52a1001a9c310b46) don't shut down machines that are already suspended - [`3e71e7c`](https://github.com/sixdimensionalarray/esxidown/commit/3e71e7cb038ec8321d1936b3f5926fb19ad5524b) changed the wrong line ### 📊 Changes **1 file changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `esxidown.sh` (+10 -10) </details> ### 📄 Description Hi, I found your script as I was searching for an easy way to power down my testing server in the evening. To fit my needs I changed some small things namely: - set maintenance mode first just to prevent other machines from powering up, while I want to power down. - reduced wait time and higher the times a shutdown is tried also the script would always wait a full minute even if a machine immediately powers down. - changed query for vmid I have some annotations in my machines, with the old query he also wanted to power down my annotations - ignore machines that are already in suspended mode do what it says. I hope you find this helpful as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:03:21 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/esxidown#3
No description provided.