[GH-ISSUE #909] [RTL] Hebrew #392

New issue

Open

opened 2026-02-28 00:01:59 +03:00 by kerem · 9 comments

kerem commented 2026-02-28 00:01:59 +03:00

Owner

Copy link

Originally created by @itsik-b on GitHub (Jul 3, 2018).
Original GitHub issue: https://github.com/SpacehuhnTech/esp8266_deauther/issues/909

I've translated lang file for HEBREW language. I've managed to create the he.lang.gz file and created the webfile.h with the webConverter.py utility.
but it doesn't seem to work. I've set the WEBSPIFFS option in SETTINGS and confirmed that the file he.lang.gz copied to SPIFFS.

• before coping the files to SPIFFS, I got msg "lang he.lang.gz file not found" on serial monitor. after copying it there isn't any message for missing lang file, but still works in english.

What am I missing ?
he.lang.gz
he.lang.txt

Originally created by @itsik-b on GitHub (Jul 3, 2018). Original GitHub issue: https://github.com/SpacehuhnTech/esp8266_deauther/issues/909 I've translated lang file for HEBREW language. I've managed to create the he.lang.gz file and created the webfile.h with the webConverter.py utility. but it doesn't seem to work. I've set the WEBSPIFFS option in SETTINGS <enabled> and confirmed that the file he.lang.gz copied to SPIFFS. * before coping the files to SPIFFS, I got msg "lang he.lang.gz file not found" on serial monitor. after copying it there isn't any message for missing lang file, but still works in english. What am I missing ? [he.lang.gz](https://github.com/spacehuhn/esp8266_deauther/files/2158840/he.lang.gz) [he.lang.txt](https://github.com/spacehuhn/esp8266_deauther/files/2158849/he.lang.txt)

kerem added the

translation

label 2026-02-28 00:01:59 +03:00

kerem commented 2026-02-28 00:02:00 +03:00

Author

Owner

Copy link

@tobozo commented on GitHub (Jul 3, 2018):

Some of the slashed quotes are mistyped (found one with a space between / and "), this makes the JSON parsing fail and the webUI loads the default language.

You can use this tool to pre-validate your JSON.
Or lazy fix: replace all slashed " quotes by directional signs such as « and »

<!-- gh-comment-id:402117636 --> @tobozo commented on GitHub (Jul 3, 2018): Some of the slashed quotes are mistyped (found one with a space between / and "), this makes the JSON parsing fail and the webUI loads the default language.  You can use [this tool](https://jsoneditoronline.org/) to pre-validate your JSON. Or lazy fix: replace all slashed \" quotes by directional signs such as « and »

kerem commented 2026-02-28 00:02:00 +03:00

Author

Owner

Copy link

@itsik-b commented on GitHub (Jul 3, 2018):

I removed all escape signs... still not good.
I've tried to change to RU lang, didn't change either, may be the problem is the lack of support on utf-8 files ?

<!-- gh-comment-id:402168140 --> @itsik-b commented on GitHub (Jul 3, 2018): I removed all escape signs... still not good. I've tried to change to RU lang, didn't change either, may be the problem is the lack of support on utf-8 files ?

kerem commented 2026-02-28 00:02:00 +03:00

Author

Owner

Copy link

@tobozo commented on GitHub (Jul 3, 2018):

Please submit your changes so we can cross-verify (i.e use gist or json validator online or pastebin).

I doubt there's a problem with utf8 otherwise we'd already know.

If the file is valid JSON and correctly zipped then it's a full browser problem, but I guess you already have Hebrew installed on the phone you're using to test this, right ?

One way to test the ESP is doing its part is to directly access the he.lang(.gz) file from your mobile browser.

Another lazy test: overwrite a language file you know is working (e.g. German) with the hebrew file, then load this language from the webUI, and tell us what you get.

<!-- gh-comment-id:402188227 --> @tobozo commented on GitHub (Jul 3, 2018): Please submit your changes so we can cross-verify (i.e use gist or json validator online or pastebin). I doubt there's a problem with utf8 otherwise we'd already know. If the file is valid JSON and correctly zipped then it's a full browser problem, but I guess you already have Hebrew installed on the phone you're using to test this, right ? One way to test the ESP is doing its part is to directly access the he.lang(.gz) file from your mobile browser. Another lazy test: overwrite a language file you know is working (e.g. German) with the hebrew file, then load this language from the webUI, and tell us what you get.

kerem commented 2026-02-28 00:02:00 +03:00

Author

Owner

Copy link

@itsik-b commented on GitHub (Jul 4, 2018):

Attached the clean lang file, I can't find errors in it.

Hebrew lang installed on my browsers :) (desktop and mobile phone)

I've tested it from the ESP (http://deauth.me/web/lang/he.lang.gz) the JSON file was loaded O.K. :

he_clean.lang.txt
he.lang.gz

<!-- gh-comment-id:402383401 --> @itsik-b commented on GitHub (Jul 4, 2018): Attached the clean lang file, I can't find errors in it. Hebrew lang installed on my browsers :) (desktop and mobile phone) I've tested it from the ESP (http://deauth.me/web/lang/he.lang.gz) the JSON file was loaded O.K. :  [he_clean.lang.txt](https://github.com/spacehuhn/esp8266_deauther/files/2162095/he_clean.lang.txt) [he.lang.gz](https://github.com/spacehuhn/esp8266_deauther/files/2162096/he.lang.gz)

kerem commented 2026-02-28 00:02:00 +03:00

Author

Owner

Copy link

@itsik-b commented on GitHub (Jul 4, 2018):

got it to work. wifi.h needed to be fixed:

Now I'll be able to format it better... I'll upload the fixed lang file when I'm done.

<!-- gh-comment-id:402388369 --> @itsik-b commented on GitHub (Jul 4, 2018): got it to work. wifi.h needed to be fixed:  Now I'll be able to format it better... I'll upload the fixed lang file when I'm done.

kerem commented 2026-02-28 00:02:01 +03:00

Author

Owner

Copy link

@itsik-b commented on GitHub (Jul 4, 2018):

Is there a way to make the text right alignment ?

<!-- gh-comment-id:402390989 --> @itsik-b commented on GitHub (Jul 4, 2018): Is there a way to make the text right alignment ? 

kerem commented 2026-02-28 00:02:01 +03:00

Author

Owner

Copy link

@tobozo commented on GitHub (Jul 4, 2018):

there are different approaches to that

1. RTL page html { direction: rtl; }
2. RTL layout section { direction: rtl; }
3. RTL blocks span { direction :rtl; }

Note that depending on the layout you sometimes have to use both directions in the same document:

 html { direction: ltr; } 
 span { direction: rtl; }

Full RTL page will probably trigger the directional anomalies you usually find on LTR-only layouts, where parts are explicitely using text-align:left.

If you come to modify the css, make sure you prefix all your extra directives like this:

[lang="he"] div.blah > span.meh { 
  direction: rtl; 
  text-align:left 
}

<!-- gh-comment-id:402394621 --> @tobozo commented on GitHub (Jul 4, 2018): there are different approaches to that 1) RTL page `html { direction: rtl; }` 2) RTL layout `section { direction: rtl; }` 3) RTL blocks `span { direction :rtl; }` Note that depending on the layout you sometimes have to use both directions in the same document: ``` html { direction: ltr; } span { direction: rtl; } ``` Full RTL page will probably trigger the directional anomalies you usually find on LTR-only layouts, where parts are explicitely using text-align:left. If you come to modify the css, make sure you prefix all your extra directives like this: ``` [lang="he"] div.blah > span.meh { direction: rtl; text-align:left } ```

kerem commented 2026-02-28 00:02:01 +03:00

Author

Owner

Copy link

@itsik-b commented on GitHub (Jul 4, 2018):

I don't want to mess the other LTR languages.
I can add before every RTL text ‮ (Unicode Bidirectional) which will work as RTL text.
But I need to change the alignment of the paragraphs. any ideas how to do it without affecting the other LTR langs ?

<!-- gh-comment-id:402415169 --> @itsik-b commented on GitHub (Jul 4, 2018): I don't want to mess the other LTR languages. I can add before every RTL text `&#x202E;` (Unicode Bidirectional) which will work as RTL text. But I need to change the alignment of the paragraphs. any ideas how to do it without affecting the other LTR langs ?

kerem commented 2026-02-28 00:02:01 +03:00

Author

Owner

Copy link

@tobozo commented on GitHub (Jul 4, 2018):

the bidi byte won't fix the left/right alignment problems, and it's implicitly inserted anyway

if things are made correctly on the layout when you switch languages, all you need is CSS, you can use it in a way it won't interfer with LTR languages.

e.g. html[lang="he"] your.directive.here

in order to get the right lang attribute to the <html> tag, you need to modify a function in site.js as follows:

function parseLang(fileStr){
	langJson = JSON.parse(fileStr);
	if(langJson["lang"] != "en"){// no need to update the HTML	
		var elements = document.querySelectorAll("[data-translate]");
		for (i = 0; i < elements.length; i++) {
			var element = elements[i];
			element.innerHTML = lang(element.getAttribute("data-translate"));
		}
	}
        document.querySelector('html').setAttribute("lang", langJson["lang"] );
	if(typeof load !== 'undefined') load();
}

<!-- gh-comment-id:402420914 --> @tobozo commented on GitHub (Jul 4, 2018): the bidi byte won't fix the left/right alignment problems, and it's implicitly inserted anyway if things are made correctly on the layout when you switch languages, all you need is CSS, you can use it in a way it won't interfer with LTR languages. e.g. `html[lang="he"] your.directive.here` in order to get the right `lang` attribute to the `<html>` tag, you need to modify a function in [site.js](https://github.com/spacehuhn/esp8266_deauther/blob/master/web_interface/js/site.js#L93) as follows: ``` function parseLang(fileStr){ langJson = JSON.parse(fileStr); if(langJson["lang"] != "en"){// no need to update the HTML var elements = document.querySelectorAll("[data-translate]"); for (i = 0; i < elements.length; i++) { var element = elements[i]; element.innerHTML = lang(element.getAttribute("data-translate")); } } document.querySelector('html').setAttribute("lang", langJson["lang"] ); if(typeof load !== 'undefined') load(); } ```

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

v2

v3

v1

2.6.1

2.6.0

2.6.0-rc3

2.6.0-rc2

2.6.0-rc1

2.5.0-rc2

2.5.0-rc1

v2.1.0

v2.0.5

v2.1.4

v2.0

v1.6-testing

v.1.6

v.1.5

v.1.4

v.1.3

v1.2

v1.1

1.0

Labels

Clear labels   

best of

  

bug

  

development

  

discussion

  

documentation

  

duplicate

  

feature request

  

help wanted

  

help wanted

  

improvement

  

pinned

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

stale

  

translation

  

v3

  

wontfix

No labels

best of

bug

development

discussion

documentation

duplicate

feature request

help wanted

help wanted

improvement

pinned

pull-request

question

stale

translation

v3

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/esp8266_deauther#392

No description provided.