[PR #1388] [MERGED] Fix for setting web AP channel #1149

New issue

Closed

opened 2026-02-28 00:06:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:06:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/SpacehuhnTech/esp8266_deauther/pull/1388
Author: @Metamogul
Created: 1/24/2021
Status: ✅ Merged
Merged: 1/24/2021
Merged by: @spacehuhn

Base: v2 ← Head: v2

📝 Commits (2)

6c6727e Deleted wifi channel set without effect
33c97ba When initializing wifi, use actual channel from settings instead of always using channel 1

📊 Changes

2 files changed (+3 additions, -6 deletions)

View changed files

📝 esp8266_deauther/esp8266_deauther.ino (+1 -4)
📝 esp8266_deauther/wifi.cpp (+2 -2)

📄 Description

Describe the bug
After downloading and trying out this project I discovered that no matter what AP channel I chose in the settings in the web interface the AP would always start in channel 1. This seems to be related to most probably deprecated and left over code for changing the AP channel.

To Reproduce
Steps to reproduce the behavior:

Compile the project and load it onto your device
Connect to web interface via wifi
Go to settings and set the AP channel to something different than the default channel 1
Save and reload settings to confirm successful save
Reboot and check wifi channel of connected client (e.g. with iwconfig)
Actual channel is still 1 no matter the settings

Expected behavior
Changing the wifi channel in settings should lead to the AP actually switching to the new channel after reboot

Environment:

Version: 2.6.0
Hardware: Wemos D1 Mini Pro

Fix
This behaviour is fixed with this pull request.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SpacehuhnTech/esp8266_deauther/pull/1388 **Author:** [@Metamogul](https://github.com/Metamogul) **Created:** 1/24/2021 **Status:** ✅ Merged **Merged:** 1/24/2021 **Merged by:** [@spacehuhn](https://github.com/spacehuhn) **Base:** `v2` ← **Head:** `v2` --- ### 📝 Commits (2) - [`6c6727e`](https://github.com/SpacehuhnTech/esp8266_deauther/commit/6c6727eff8aef445025290f96b9fdcd0b6f47223) Deleted wifi channel set without effect - [`33c97ba`](https://github.com/SpacehuhnTech/esp8266_deauther/commit/33c97bab9975b37e19c7beaa0f7e0a215252fd4d) When initializing wifi, use actual channel from settings instead of always using channel 1 ### 📊 Changes **2 files changed** (+3 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `esp8266_deauther/esp8266_deauther.ino` (+1 -4) 📝 `esp8266_deauther/wifi.cpp` (+2 -2) </details> ### 📄 Description **Describe the bug** After downloading and trying out this project I discovered that no matter what AP channel I chose in the settings in the web interface the AP would always start in channel 1. This seems to be related to most probably deprecated and left over code for changing the AP channel. **To Reproduce** Steps to reproduce the behavior: 1. Compile the project and load it onto your device 2. Connect to web interface via wifi 3. Go to settings and set the AP channel to something different than the default channel 1 4. Save and reload settings to confirm successful save 5. Reboot and check wifi channel of connected client (e.g. with iwconfig) 6. Actual channel is still 1 no matter the settings **Expected behavior** Changing the wifi channel in settings should lead to the AP actually switching to the new channel after reboot **Environment:** - Version: 2.6.0 - Hardware: Wemos D1 Mini Pro **Fix** This behaviour is fixed with this pull request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>