[PR #26] [MERGED] fix for APs > maxResults creating invalid json, resulting in empty APlist #1031

Closed
opened 2026-02-28 00:06:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/SpacehuhnTech/esp8266_deauther/pull/26
Author: @andrbmgi
Created: 2/18/2017
Status: Merged
Merged: 2/18/2017
Merged by: @spacehuhn

Base: masterHead: master


📝 Commits (2)

  • 0b66f10 fix for APs > maxResults creating invalid json resulting in empty AP list
  • 37b98f3 5 second timeout instead of 3

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 esp8266_deauther/APScan.cpp (+1 -1)
📝 esp8266_deauther/data.h (+2 -2)

📄 Description

When there are more than maxResults APs the generated json is invalid and thus the list stays empty.

Issue: https://github.com/spacehuhn/esp8266_deauther/issues/5


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SpacehuhnTech/esp8266_deauther/pull/26 **Author:** [@andrbmgi](https://github.com/andrbmgi) **Created:** 2/18/2017 **Status:** ✅ Merged **Merged:** 2/18/2017 **Merged by:** [@spacehuhn](https://github.com/spacehuhn) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`0b66f10`](https://github.com/SpacehuhnTech/esp8266_deauther/commit/0b66f101b05f06f13603a36f6d134c93dcc263de) fix for APs > maxResults creating invalid json resulting in empty AP list - [`37b98f3`](https://github.com/SpacehuhnTech/esp8266_deauther/commit/37b98f38793192b9623fcf314528fb8a57afc364) 5 second timeout instead of 3 ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `esp8266_deauther/APScan.cpp` (+1 -1) 📝 `esp8266_deauther/data.h` (+2 -2) </details> ### 📄 Description When there are more than maxResults APs the generated json is invalid and thus the list stays empty. Issue: https://github.com/spacehuhn/esp8266_deauther/issues/5 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:06:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/esp8266_deauther#1031
No description provided.