[GH-ISSUE #1686] Electron has serious security vulnerability #990

Closed
opened 2026-02-27 00:01:48 +03:00 by kerem · 2 comments
Owner

Originally created by @weinull on GitHub (May 12, 2020).
Original GitHub issue: https://github.com/electerm/electerm/issues/1686

Electerm version:

All versions

Operating system(linux, macos, or windows7/8/10?):

All operating system(macos,windows7/8/10,linux)

Detailed Description

Electerm did not conduct permission checks, which led to remote command execution vulnerabilities.
After testing, it affected Electerm on all operating systems.

Steps to Reproduce

1.Open Electerm and keep it running.
2.Use a browser such as Chrome / Firefox / Safari to visit the malicious site I constructed: http://orz.weinull.com/orz-001.html
3.Malicious site executes command to open calculator.

Suggestions

Generate a random token for service invocation at startup, and at the same time, ensure that the token has enough complexity to be guessed

Electerm is a very good tool, hope to develop better

Originally created by @weinull on GitHub (May 12, 2020). Original GitHub issue: https://github.com/electerm/electerm/issues/1686 ## Electerm version: All versions ## Operating system(linux, macos, or windows7/8/10?): All operating system(macos,windows7/8/10,linux) ## Detailed Description Electerm did not conduct permission checks, which led to remote command execution vulnerabilities. After testing, it affected Electerm on all operating systems. ## Steps to Reproduce 1.Open Electerm and keep it running. 2.Use a browser such as Chrome / Firefox / Safari to visit the malicious site I constructed: http://orz.weinull.com/orz-001.html 3.Malicious site executes command to open calculator. ## Suggestions Generate a random token for service invocation at startup, and at the same time, ensure that the token has enough complexity to be guessed #### Electerm is a very good tool, hope to develop better
kerem 2026-02-27 00:01:48 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@zxdong262 commented on GitHub (May 13, 2020):

@weinull Thank you for the feedback, fixed in new version.

<!-- gh-comment-id:627786656 --> @zxdong262 commented on GitHub (May 13, 2020): @weinull Thank you for the feedback, fixed in new version.
Author
Owner

@weinull commented on GitHub (May 13, 2020):

@zxdong262 I downloaded the latest version (v1.3.25), and the test on macOS found that the token check did not take effect. I can still execute the command to open the calculator by visiting the malicious site provided.

I found the cause of the problem. After Electerm exits, there are still active processes (server.js). After I update the version, there are still old versions of the process, so I can still open the calculator. I need to restart the OS or kill the process to recover.
It is recommended to stop all active processes of Electerm after exiting to avoid resource occupation.

<!-- gh-comment-id:627804472 --> @weinull commented on GitHub (May 13, 2020): @zxdong262 ~~I downloaded the latest version (v1.3.25), and the test on macOS found that the token check did not take effect. I can still execute the command to open the calculator by visiting the malicious site provided.~~ I found the cause of the problem. After Electerm exits, there are still active processes (server.js). After I update the version, there are still old versions of the process, so I can still open the calculator. I need to restart the OS or kill the process to recover. It is recommended to stop all active processes of Electerm after exiting to avoid resource occupation.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/electerm#990
No description provided.