[GH-ISSUE #959] Ask for passphrase at connection #556

Closed
opened 2026-02-26 23:59:57 +03:00 by kerem · 10 comments
Owner

Originally created by @JimboJoe on GitHub (Nov 27, 2018).
Original GitHub issue: https://github.com/electerm/electerm/issues/959

Electerm version: 0.25.37

Operating system(linux, macos, or windows?): Linux Mint 19

Expected Behavior

I would like to be able to only type passphrase for a privateKey SSH access at connection, so that the passphrase doesn't get stored on disk. I'm OK with typing the passphrase every time so that my SSH access stays secured if my laptop get stolen/hacked.

Current Behavior

I tried to leave the passphrase field blank, in the hope that it would be asked at connection, but the connection just failed.

Possible Solution

As said before, ask for passphrase at connection if passphrase field left blank.

Steps to Reproduce

Stated before.

Context (Environment)

Mean to prevent storing a privateKey passphrase.

Detailed Description

See above.

Suggestions?

See above as well 😉

Originally created by @JimboJoe on GitHub (Nov 27, 2018). Original GitHub issue: https://github.com/electerm/electerm/issues/959 <!--- Provide some basic info --> ## Electerm version: 0.25.37 ## Operating system(linux, macos, or windows?): Linux Mint 19 ## Expected Behavior <!--- Tell me what should happen --> I would like to be able to only type passphrase for a privateKey SSH access at connection, so that the passphrase doesn't get stored on disk. I'm OK with typing the passphrase every time so that my SSH access stays secured if my laptop get stolen/hacked. ## Current Behavior <!--- Tell me what happens instead of the expected behavior --> I tried to leave the passphrase field blank, in the hope that it would be asked at connection, but the connection just failed. ## Possible Solution <!--- Not obligatory, but suggest a fix/reason for the bug, --> As said before, ask for passphrase at connection if passphrase field left blank. ## Steps to Reproduce <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. Include code to reproduce, if relevant --> Stated before. ## Context (Environment) <!--- How has this issue affected you? What are you trying to accomplish? --> <!--- Providing context helps us come up with a solution that is most useful in the real world --> Mean to prevent storing a privateKey passphrase. ## Detailed Description <!--- Provide a detailed description of the change or addition you are proposing --> See above. ## Suggestions? <!--- Not a bug report, just some thoughts or suggestions? It is totally OK and welcome too --> See above as well :wink:
kerem closed this issue 2026-02-26 23:59:57 +03:00
Author
Owner

@zxdong262 commented on GitHub (Nov 28, 2018):

@JimboJoe I am working on this feature, hope I can support this soon. Similar to https://github.com/electerm/electerm/issues/836

<!-- gh-comment-id:442285708 --> @zxdong262 commented on GitHub (Nov 28, 2018): @JimboJoe I am working on this feature, hope I can support this soon. Similar to https://github.com/electerm/electerm/issues/836
Author
Owner

@JimboJoe commented on GitHub (Nov 28, 2018):

Thanks for your quick response!
It's "similar" yet different from #836: #836 is about providing a privateKey AND a user password, my use case is just about providing a privateKey, but not storing the passphrase and asking for it at every connection. I'm sure you had understood, I'm just rephrasing to avoid any misunderstood 😄

<!-- gh-comment-id:442340646 --> @JimboJoe commented on GitHub (Nov 28, 2018): Thanks for your quick response! It's "similar" yet different from #836: #836 is about providing a privateKey AND a user password, my use case is just about providing a privateKey, but not storing the passphrase and asking for it at every connection. I'm sure you had understood, I'm just rephrasing to avoid any misunderstood :smile:
Author
Owner

@zxdong262 commented on GitHub (Nov 28, 2018):

@JimboJoe I did think it is the same, now I undertand it is not. Thanks for the explaining it.

<!-- gh-comment-id:442376652 --> @zxdong262 commented on GitHub (Nov 28, 2018): @JimboJoe I did think it is the same, now I undertand it is not. Thanks for the explaining it.
Author
Owner

@zxdong262 commented on GitHub (Dec 4, 2018):

@JimboJoe New version released, check it out~

<!-- gh-comment-id:444100466 --> @zxdong262 commented on GitHub (Dec 4, 2018): @JimboJoe New version released, check it out~
Author
Owner

@JimboJoe commented on GitHub (Dec 4, 2018):

Works fine for me!
As a bonus, could you maybe not show key pressed for a password by default...? 😉
Thanks a lot!

<!-- gh-comment-id:444242944 --> @JimboJoe commented on GitHub (Dec 4, 2018): Works fine for me! As a bonus, could you maybe not show key pressed for a password by default...? :wink: Thanks a lot!
Author
Owner

@zxdong262 commented on GitHub (Dec 5, 2018):

@JimboJoe Ah, right, it is a password! Thank you for the tip!

<!-- gh-comment-id:444316253 --> @zxdong262 commented on GitHub (Dec 5, 2018): @JimboJoe Ah, right, it is a password! Thank you for the tip!
Author
Owner

@JimboJoe commented on GitHub (Dec 6, 2018):

Another linked request: in this specific case (I don't want to store the private key passphrase), if electerm is closed with an open session, it proposes to reopen the open sessions before close: if you say yes, it connects successfully... without asking for the passphrase!
So that means the passphrase is still stored somewhere, which is what we want to avoid in this use case.

<!-- gh-comment-id:444763256 --> @JimboJoe commented on GitHub (Dec 6, 2018): Another linked request: in this specific case (I don't want to store the private key passphrase), if electerm is closed with an open session, it proposes to reopen the open sessions before close: if you say yes, it connects successfully... without asking for the passphrase! So that means the passphrase is still stored somewhere, which is what we want to avoid in this use case.
Author
Owner

@zxdong262 commented on GitHub (Dec 6, 2018):

Hi, @JimboJoe, Please check you bookmark item if the passphrase is there, only when you check the save password checkbox, the passphrase or password will be saved into bookmark item. If it is stored in bookmark item, you could delete it, then try it again, let me know how it works.

<!-- gh-comment-id:444784340 --> @zxdong262 commented on GitHub (Dec 6, 2018): Hi, @JimboJoe, Please check you bookmark item if the passphrase is there, only when you check the save password checkbox, the passphrase or password will be saved into bookmark item. If it is stored in bookmark item, you could delete it, then try it again, let me know how it works.
Author
Owner

@JimboJoe commented on GitHub (Dec 6, 2018):

No, I checked prior to commenting that the password wasn't there any more (I removed it after connection).

Le 6 décembre 2018 09:10:22 GMT+01:00, ZHAO Xudong notifications@github.com a écrit :

Hi, @JimboJoe, Please check you bookmark item if the passphrase is
there, only when you check the save password checkbox, the passphrase
or password will be saved into bookmark item. If it is stored in
bookmark item, you could delete it, then try it again, let me know how
it works.

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/electerm/electerm/issues/959#issuecomment-444784340

<!-- gh-comment-id:444816471 --> @JimboJoe commented on GitHub (Dec 6, 2018): No, I checked prior to commenting that the password wasn't there any more (I removed it after connection). Le 6 décembre 2018 09:10:22 GMT+01:00, ZHAO Xudong <notifications@github.com> a écrit : >Hi, @JimboJoe, Please check you bookmark item if the passphrase is >there, only when you check the save password checkbox, the passphrase >or password will be saved into bookmark item. If it is stored in >bookmark item, you could delete it, then try it again, let me know how >it works. > >-- >You are receiving this because you were mentioned. >Reply to this email directly or view it on GitHub: >https://github.com/electerm/electerm/issues/959#issuecomment-444784340
Author
Owner

@zxdong262 commented on GitHub (Dec 6, 2018):

Removed it after connection? Should remove it before connection.

<!-- gh-comment-id:444845293 --> @zxdong262 commented on GitHub (Dec 6, 2018): Removed it after connection? Should remove it before connection.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/electerm#556
No description provided.