[GH-ISSUE #903] home dir error #523

New issue

Closed

opened 2026-02-26 23:59:50 +03:00 by kerem · 3 comments

kerem commented

2026-02-26 23:59:50 +03:00

Owner

Originally created by @blue-bird1 on GitHub (Nov 13, 2018).
Original GitHub issue: https://github.com/electerm/electerm/issues/903

Electerm version:

0.25.21

Operating system(linux, macos, or windows?):

windows

Expected Behavior

localshell in home dir .

Current Behavior

localshell in download electerm dir

Possible Solution

diff --git a/app/lib/terminal.js b/app/lib/terminal.js
index 4e4d25b..5360c2e 100644
--- a/app/lib/terminal.js
+++ b/app/lib/terminal.js
@@ -27,11 +27,12 @@ class Terminal {
     let {platform} = process
     let exe = platform.startsWith('win') ? 'powershell.exe' : 'bash'
     let argv = platform.startsWith('darwin') ? ['--login'] : []
+    let home = platform.startsWith('win') ? process.env.USERPROFILE : process.env.HOME
     this.term = pty.spawn(exe, argv, {
       name: 'xterm-color',
       cols: cols || 80,
       rows: rows || 24,
-      cwd: process.env.HOME,
+      cwd: home,
       env: process.env
     })
     return Promise.resolve()

Steps to Reproduce

Context (Environment)

Detailed Description

Suggestions?

windows not have process.env.HOME, but have process.env.USERPROFILE :

Originally created by @blue-bird1 on GitHub (Nov 13, 2018). Original GitHub issue: https://github.com/electerm/electerm/issues/903  ## Electerm version: 0.25.21 ## Operating system(linux, macos, or windows?): windows ## Expected Behavior  localshell in home dir . ## Current Behavior  localshell in download electerm dir ## Possible Solution  ``` diff --git a/app/lib/terminal.js b/app/lib/terminal.js index 4e4d25b..5360c2e 100644 --- a/app/lib/terminal.js +++ b/app/lib/terminal.js @@ -27,11 +27,12 @@ class Terminal { let {platform} = process let exe = platform.startsWith('win') ? 'powershell.exe' : 'bash' let argv = platform.startsWith('darwin') ? ['--login'] : [] + let home = platform.startsWith('win') ? process.env.USERPROFILE : process.env.HOME this.term = pty.spawn(exe, argv, { name: 'xterm-color', cols: cols || 80, rows: rows || 24, - cwd: process.env.HOME, + cwd: home, env: process.env }) return Promise.resolve() ``` ## Steps to Reproduce   1. 2. 3. 4. ## Context (Environment)   ## Detailed Description  ## Suggestions?  windows not have process.env.HOME, but have process.env.USERPROFILE :

kerem

2026-02-26 23:59:50 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-26 23:59:51 +03:00

Author

Owner

@zxdong262 commented on GitHub (Nov 13, 2018):

@blue-bird1 Thanks, I will try.

@zxdong262 commented on GitHub (Nov 13, 2018): @blue-bird1 Thanks, I will try.

kerem commented

2026-02-26 23:59:51 +03:00

Author

Owner

@blue-bird1 commented on GitHub (Nov 13, 2018):

@zxdong262 How should I only build a Windows package in Linux

@blue-bird1 commented on GitHub (Nov 13, 2018): @zxdong262 How should I only build a Windows package in Linux

kerem commented

2026-02-26 23:59:51 +03:00

Author

Owner

@zxdong262 commented on GitHub (Nov 14, 2018):

@blue-bird1 Possible by using wine, or some pre-built docker image, I did build some simpler windows app in linux, but electerm is more complicated, too much trouble I guess, so I use appveyor to do the build.

@zxdong262 commented on GitHub (Nov 14, 2018): @blue-bird1 Possible by using wine, or some pre-built docker image, I did build some simpler windows app in linux, but electerm is more complicated, too much trouble I guess, so I use appveyor to do the build.

kerem referenced this issue

2026-02-27 00:55:40 +03:00

[PR #524] [MERGED] fix #523 after connection close, change terminal status to error #3128