[GH-ISSUE #885] set localshell #513

Closed
opened 2026-02-26 23:59:48 +03:00 by kerem · 5 comments
Owner

Originally created by @blue-bird1 on GitHub (Nov 9, 2018).
Original GitHub issue: https://github.com/electerm/electerm/issues/885

Electerm version:

0.25.12

Operating system(linux, macos, or windows?):

windows

Expected Behavior

customize localshell to gitbash

Current Behavior

Hardcoded to powershell.exe.(It seems that if there is no powershell it will be a disaster, Lead to some unknown bugs)

Possible Solution

Steps to Reproduce

1.in windows open app, get a powershell
2.
3.
4.

Context (Environment)

Detailed Description

Suggestions?

Originally created by @blue-bird1 on GitHub (Nov 9, 2018). Original GitHub issue: https://github.com/electerm/electerm/issues/885 <!--- Provide some basic info --> ## Electerm version: 0.25.12 ## Operating system(linux, macos, or windows?): windows ## Expected Behavior <!--- Tell me what should happen --> customize localshell to gitbash ## Current Behavior <!--- Tell me what happens instead of the expected behavior --> [Hardcoded to powershell.exe](https://github.com/electerm/electerm/blob/aa6c573bdee6e1784637d803db840308dbadcb36/app/lib/terminal.js#L28).(It seems that if there is no powershell it will be a disaster, Lead to some unknown bugs) ## Possible Solution <!--- Not obligatory, but suggest a fix/reason for the bug, --> ## Steps to Reproduce <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. Include code to reproduce, if relevant --> 1.in windows open app, get a powershell 2. 3. 4. ## Context (Environment) <!--- How has this issue affected you? What are you trying to accomplish? --> <!--- Providing context helps us come up with a solution that is most useful in the real world --> ## Detailed Description <!--- Provide a detailed description of the change or addition you are proposing --> ## Suggestions? <!--- Not a bug report, just some thoughts or suggestions? It is totally OK and welcome too -->
kerem 2026-02-26 23:59:48 +03:00
  • closed this issue
  • added the
    feature
    label
Author
Owner

@zxdong262 commented on GitHub (Nov 27, 2018):

I remembered I used cmd.exe at first, but for some reason(I do not remember the reason now), it do not work, so I changed to powershell.exe, I checked vscode, it use pwershell.exe as default too, I guess for the same reason.

<!-- gh-comment-id:441956428 --> @zxdong262 commented on GitHub (Nov 27, 2018): I remembered I used cmd.exe at first, but for some reason(I do not remember the reason now), it do not work, so I changed to `powershell.exe`, I checked vscode, it use `pwershell.exe` as default too, I guess for the same reason.
Author
Owner

@zxdong262 commented on GitHub (Jan 29, 2019):

#1116

<!-- gh-comment-id:458382396 --> @zxdong262 commented on GitHub (Jan 29, 2019): #1116
Author
Owner

@zxdong262 commented on GitHub (Jan 29, 2019):

I may release a new version with custom exec support in a few days. #1117

<!-- gh-comment-id:458390854 --> @zxdong262 commented on GitHub (Jan 29, 2019): I may release a new version with custom exec support in a few days. #1117
Author
Owner

@zxdong262 commented on GitHub (Jan 29, 2019):

Hi, @blue-bird1 Released a new version with custom exec support in settings.

<!-- gh-comment-id:458413261 --> @zxdong262 commented on GitHub (Jan 29, 2019): Hi, @blue-bird1 Released a new version with custom exec support in settings.
Author
Owner

@zxdong262 commented on GitHub (Jan 29, 2019):

#1117

<!-- gh-comment-id:458413308 --> @zxdong262 commented on GitHub (Jan 29, 2019): #1117
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/electerm#513
No description provided.