[GH-ISSUE #3573] Profiles should be encrypted #2448

Closed
opened 2026-02-27 00:07:25 +03:00 by kerem · 7 comments
Owner

Originally created by @zxdong262 on GitHub (Aug 26, 2024).
Original GitHub issue: https://github.com/electerm/electerm/issues/3573

Hello!
There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password.

Originally posted by @AASabancev in https://github.com/electerm/electerm/discussions/3570

Originally created by @zxdong262 on GitHub (Aug 26, 2024). Original GitHub issue: https://github.com/electerm/electerm/issues/3573 Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password. _Originally posted by @AASabancev in https://github.com/electerm/electerm/discussions/3570_
kerem closed this issue 2026-02-27 00:07:25 +03:00
Author
Owner

@emoxam commented on GitHub (Jan 16, 2025):

Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password.

Originally posted by @AASabancev in #3570

Where did you find "encryption of bookmarks using password" option?

<!-- gh-comment-id:2595652643 --> @emoxam commented on GitHub (Jan 16, 2025): > Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password. > > _Originally posted by [@AASabancev](https://github.com/AASabancev) in [#3570](https://github.com/electerm/electerm/discussions/3570)_ Where did you find "encryption of bookmarks using password" option?
Author
Owner

@zxdong262 commented on GitHub (Jan 16, 2025):

Thank you for the feedback, you are right, keys should be encrypted too, would update in next release

Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password.
Originally posted by @AASabancev in #3570

Where did you find "encryption of bookmarks using password" option?

<!-- gh-comment-id:2595852175 --> @zxdong262 commented on GitHub (Jan 16, 2025): Thank you for the feedback, you are right, keys should be encrypted too, would update in next release > > Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password. > > _Originally posted by [@AASabancev](https://github.com/AASabancev) in [#3570](https://github.com/electerm/electerm/discussions/3570)_ > > Where did you find "encryption of bookmarks using password" option?
Author
Owner

@emoxam commented on GitHub (Jan 16, 2025):

Thank you for the feedback, you are right, keys should be encrypted too, would update in next release

Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password.
Originally posted by @AASabancev in #3570

Where did you find "encryption of bookmarks using password" option?

Thanks! But i don't understand what option we are talking about?) Is there any master password that encrypts the data ?

<!-- gh-comment-id:2595862473 --> @emoxam commented on GitHub (Jan 16, 2025): > Thank you for the feedback, you are right, keys should be encrypted too, would update in next release > > > > Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password. > > > _Originally posted by [@AASabancev](https://github.com/AASabancev) in [#3570](https://github.com/electerm/electerm/discussions/3570)_ > > > > > > Where did you find "encryption of bookmarks using password" option? Thanks! But i don't understand what option we are talking about?) Is there any master password that encrypts the data ?
Author
Owner

@zxdong262 commented on GitHub (Jan 16, 2025):

Thank you for the feedback, you are right, keys should be encrypted too, would update in next release

Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password.
Originally posted by @AASabancev in #3570

Where did you find "encryption of bookmarks using password" option?

Thanks! But i don't understand what option we are talking about?) Is there any master password that encrypts the data ?

In data sync, there is a password input, optional, when set, the data would be encrypted and upload the sync server, the profile already encrypted when password set, I forget about it

<!-- gh-comment-id:2597068539 --> @zxdong262 commented on GitHub (Jan 16, 2025): > > Thank you for the feedback, you are right, keys should be encrypted too, would update in next release > > > > Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password. > > > > _Originally posted by [@AASabancev](https://github.com/AASabancev) in [#3570](https://github.com/electerm/electerm/discussions/3570)_ > > > > > > > > > Where did you find "encryption of bookmarks using password" option? > > Thanks! But i don't understand what option we are talking about?) Is there any master password that encrypts the data ? In data sync, there is a password input, optional, when set, the data would be encrypted and upload the sync server, the profile already encrypted when password set, I forget about it
Author
Owner

@emoxam commented on GitHub (Jan 17, 2025):

Thank you for the feedback, you are right, keys should be encrypted too, would update in next release

Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password.
Originally posted by @AASabancev in #3570

Where did you find "encryption of bookmarks using password" option?

Thanks! But i don't understand what option we are talking about?) Is there any master password that encrypts the data ?

In data sync, there is a password input, optional, when set, the data would be encrypted and upload the sync server, the profile already encrypted when password set, I forget about it

I want encrypt but i don't want to upload it anywhere, should i set password? How can i check that data is encrypted ?

<!-- gh-comment-id:2597523176 --> @emoxam commented on GitHub (Jan 17, 2025): > > > Thank you for the feedback, you are right, keys should be encrypted too, would update in next release > > > > > Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password. > > > > > _Originally posted by [@AASabancev](https://github.com/AASabancev) in [#3570](https://github.com/electerm/electerm/discussions/3570)_ > > > > > > > > > > > > Where did you find "encryption of bookmarks using password" option? > > > > > > Thanks! But i don't understand what option we are talking about?) Is there any master password that encrypts the data ? > > In data sync, there is a password input, optional, when set, the data would be encrypted and upload the sync server, the profile already encrypted when password set, I forget about it I want encrypt but i don't want to upload it anywhere, should i set password? How can i check that data is encrypted ?
Author
Owner

@zxdong262 commented on GitHub (Jan 21, 2025):

Thank you for the feedback, you are right, keys should be encrypted too, would update in next release

Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password.
Originally posted by @AASabancev in #3570

Where did you find "encryption of bookmarks using password" option?

Thanks! But i don't understand what option we are talking about?) Is there any master password that encrypts the data ?

In data sync, there is a password input, optional, when set, the data would be encrypted and upload the sync server, the profile already encrypted when password set, I forget about it

I want encrypt but i don't want to upload it anywhere, should i set password? How can i check that data is encrypted ?

No that option yet, think about this: any private key in ~/.ssh is not encrypted, do you worry about its safety?

<!-- gh-comment-id:2603993889 --> @zxdong262 commented on GitHub (Jan 21, 2025): > > > > Thank you for the feedback, you are right, keys should be encrypted too, would update in next release > > > > > > Hello! There is now encryption of bookmarks using password, however, encryption does not work on profiles. And in profiles private keys are saved in open form. I think it is important to enable encryption of profiles with the same password. > > > > > > _Originally posted by [@AASabancev](https://github.com/AASabancev) in [#3570](https://github.com/electerm/electerm/discussions/3570)_ > > > > > > > > > > > > > > > Where did you find "encryption of bookmarks using password" option? > > > > > > > > > Thanks! But i don't understand what option we are talking about?) Is there any master password that encrypts the data ? > > > > > > In data sync, there is a password input, optional, when set, the data would be encrypted and upload the sync server, the profile already encrypted when password set, I forget about it > > I want encrypt but i don't want to upload it anywhere, should i set password? How can i check that data is encrypted ? No that option yet, think about this: any private key in ~/.ssh is not encrypted, do you worry about its safety?
Author
Owner

@emoxam commented on GitHub (Jan 21, 2025):

do you worry about its safety?

I didn't think about it..

<!-- gh-comment-id:2604134706 --> @emoxam commented on GitHub (Jan 21, 2025): > do you worry about its safety? I didn't think about it..
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/electerm#2448
No description provided.