[GH-ISSUE #407] incorrect parsed ssh-config items #234

Closed
opened 2026-02-26 23:58:53 +03:00 by kerem · 1 comment
Owner

Originally created by @ihipop on GitHub (Apr 27, 2018).
Original GitHub issue: https://github.com/electerm/electerm/issues/407

https://github.com/electerm/electerm/issues/378#issuecomment-377481283

this example will end up in these items in bookmark

image

Because lack of these code

let {param, value, config} = c
if (param !== 'Host') {
      return null
}

github.com/electerm/electerm@2688810e28

consider use a ssh-config parse library or add Host para check?

Originally created by @ihipop on GitHub (Apr 27, 2018). Original GitHub issue: https://github.com/electerm/electerm/issues/407 https://github.com/electerm/electerm/issues/378#issuecomment-377481283 this example will end up in these items in bookmark ![image](https://user-images.githubusercontent.com/423077/39354823-1e079eec-4a3e-11e8-939d-d31e79c8493d.png) Because lack of these code ```js let {param, value, config} = c if (param !== 'Host') { return null } ``` https://github.com/electerm/electerm/commit/2688810e28076dea57d6bbcc528301beb975f71f?diff=split consider use a `ssh-config` parse library or add `Host` para check?
kerem 2026-02-26 23:58:53 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@ihipop commented on GitHub (Apr 27, 2018):

https://github.com/electerm/electerm/pull/387

<!-- gh-comment-id:384915201 --> @ihipop commented on GitHub (Apr 27, 2018): https://github.com/electerm/electerm/pull/387
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/electerm#234
No description provided.