[PR #455] [MERGED] fix: resolve issues with signing document stickiness #984

New issue

Closed

opened 2026-02-26 19:31:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:31:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/455
Author: @Mythie
Created: 9/28/2023
Status: ✅ Merged
Merged: 9/28/2023
Merged by: @Mythie

Base: feat/refresh ← Head: fix/432-signee-doc-version-doesnt-have-sticky-signing-area

📝 Commits (1)

4885cf5 fix: resolve issues with signing document stickiness

📊 Changes

20 files changed (+66 additions, -43 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/admin/layout.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/documents/[id]/page.tsx (+5 -5)
📝 apps/web/src/app/(dashboard)/documents/page.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/layout.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/settings/billing/page.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/settings/password/page.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/settings/profile/page.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/complete/page.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/complete/share-button.tsx (+2 -2)
📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+7 -1)
📝 apps/web/src/app/(signing)/sign/[token]/layout.tsx (+3 -3)
📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+2 -2)
📝 apps/web/src/app/not-found.tsx (+1 -1)
📝 apps/web/src/components/forms/edit-document/add-fields.action.ts (+2 -2)
📝 apps/web/src/components/forms/edit-document/add-signers.action.ts (+2 -2)
📝 apps/web/src/components/forms/edit-document/add-subject.action.ts (+2 -2)
📝 packages/lib/next-auth/get-server-session.ts (+7 -7)
📝 packages/lib/universal/upload/server-actions.ts (+1 -1)
📝 packages/trpc/server/context.ts (+9 -2)
📝 packages/ui/primitives/dialog.tsx (+16 -6)

📄 Description

Removes an overflow which breaks element stickiness, also added enhancements to stickiness based on authentication state.

Resolves #432

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/455 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 9/28/2023 **Status:** ✅ Merged **Merged:** 9/28/2023 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `feat/refresh` ← **Head:** `fix/432-signee-doc-version-doesnt-have-sticky-signing-area` --- ### 📝 Commits (1) - [`4885cf5`](https://github.com/documenso/documenso/commit/4885cf5154e7772c1e9b1e99d83b64e5108d75bd) fix: resolve issues with signing document stickiness ### 📊 Changes **20 files changed** (+66 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/admin/layout.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/documents/[id]/page.tsx` (+5 -5) 📝 `apps/web/src/app/(dashboard)/documents/page.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/layout.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/settings/billing/page.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/settings/password/page.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/settings/profile/page.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/complete/page.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/complete/share-button.tsx` (+2 -2) 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+7 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/layout.tsx` (+3 -3) 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+2 -2) 📝 `apps/web/src/app/not-found.tsx` (+1 -1) 📝 `apps/web/src/components/forms/edit-document/add-fields.action.ts` (+2 -2) 📝 `apps/web/src/components/forms/edit-document/add-signers.action.ts` (+2 -2) 📝 `apps/web/src/components/forms/edit-document/add-subject.action.ts` (+2 -2) 📝 `packages/lib/next-auth/get-server-session.ts` (+7 -7) 📝 `packages/lib/universal/upload/server-actions.ts` (+1 -1) 📝 `packages/trpc/server/context.ts` (+9 -2) 📝 `packages/ui/primitives/dialog.tsx` (+16 -6) </details> ### 📄 Description Removes an overflow which breaks element stickiness, also added enhancements to stickiness based on authentication state. Resolves #432 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:31:19 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#984

No description provided.

Rows
Columns