[PR #454] [MERGED] fix: disable cancel button when there is no window history #983

Closed
opened 2026-02-26 19:31:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/454
Author: @Mythie
Created: 9/28/2023
Status: Merged
Merged: 9/28/2023
Merged by: @Mythie

Base: feat/refreshHead: fix/446-cancel-cta-does-nothing-when-a-signer-opens-the-document


📝 Commits (1)

  • af042a6 fix: disable cancel button when there is no window history

📊 Changes

2 files changed (+1 additions, -1 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+1 -0)
📝 packages/lib/server-only/document/viewed-document.ts (+0 -1)

📄 Description

Disable the cancel button when there are 1 or fewer entries in window.history, this enables cancellation to go back when signing a document in the Inbox while disabling it when navigating from an email.

Resolves #446


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/454 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 9/28/2023 **Status:** ✅ Merged **Merged:** 9/28/2023 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `feat/refresh` ← **Head:** `fix/446-cancel-cta-does-nothing-when-a-signer-opens-the-document` --- ### 📝 Commits (1) - [`af042a6`](https://github.com/documenso/documenso/commit/af042a62cd519eb567047c227f38e47bb344c1f2) fix: disable cancel button when there is no window history ### 📊 Changes **2 files changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+1 -0) 📝 `packages/lib/server-only/document/viewed-document.ts` (+0 -1) </details> ### 📄 Description Disable the cancel button when there are 1 or fewer entries in `window.history`, this enables cancellation to go back when signing a document in the Inbox while disabling it when navigating from an email. Resolves #446 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:31:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#983
No description provided.