[PR #342] [MERGED] feat: add dialog to confirm signing #894

New issue

Closed

opened 2026-02-26 19:30:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:30:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/342
Author: @ephraimduncan
Created: 9/2/2023
Status: ✅ Merged
Merged: 11/14/2023
Merged by: @Mythie

Base: feat/refresh ← Head: feat/confirm-sign-dailog

📝 Commits (9)

b4edd22 feat: add dialog to confirm signing
0be267c feat: add loading spinner when signing
261aa13 fix: minor updates
64c357a chore: minor updates based on code review
7d135e6 chore: fixes from code review
eceeb1f chore: fix merge conflicts with feat/refresh
8aa9e19 Merge branch 'feat/refresh' into feat/confirm-sign-dailog
0f40298 fix: code style updates
80eb21d chore: use named export

📊 Changes

2 files changed (+85 additions, -4 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+8 -4)
➕ apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx (+77 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/342 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 9/2/2023 **Status:** ✅ Merged **Merged:** 11/14/2023 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `feat/refresh` ← **Head:** `feat/confirm-sign-dailog` --- ### 📝 Commits (9) - [`b4edd22`](https://github.com/documenso/documenso/commit/b4edd228b667dff743c7f77cba9b25dc5a11a369) feat: add dialog to confirm signing - [`0be267c`](https://github.com/documenso/documenso/commit/0be267c4060a3c90ee5f26e8b8efca896fb2188c) feat: add loading spinner when signing - [`261aa13`](https://github.com/documenso/documenso/commit/261aa138118ab94bd0aa6acabe635ddee1caada3) fix: minor updates - [`64c357a`](https://github.com/documenso/documenso/commit/64c357a784e6c541f11d3a3922dc02df70342501) chore: minor updates based on code review - [`7d135e6`](https://github.com/documenso/documenso/commit/7d135e672428f419830c87c34f6bc4ebe2d5e322) chore: fixes from code review - [`eceeb1f`](https://github.com/documenso/documenso/commit/eceeb1faa71fae3ac69e9c27ba76aadd28ef7f75) chore: fix merge conflicts with feat/refresh - [`8aa9e19`](https://github.com/documenso/documenso/commit/8aa9e195fb9246660354079641be5b7f5c6003cd) Merge branch 'feat/refresh' into feat/confirm-sign-dailog - [`0f40298`](https://github.com/documenso/documenso/commit/0f40298edc6c31f2de08183e950dc7d1a80e6384) fix: code style updates - [`80eb21d`](https://github.com/documenso/documenso/commit/80eb21d46d3d110ee8f386de00d8cbf77fd090fc) chore: use named export ### 📊 Changes **2 files changed** (+85 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+8 -4) ➕ `apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx` (+77 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:30:56 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:32:50 +03:00

[PR #1042] [MERGED] feat: add sticky behavior to pricing options container #1339

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#894

No description provided.

Rows
Columns