[PR #293] [MERGED] refactor: extract common components into UI package #854

Closed
opened 2026-02-26 19:30:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/293
Author: @dguyen
Created: 8/23/2023
Status: Merged
Merged: 8/23/2023
Merged by: @Mythie

Base: feat/refreshHead: feat/refactor-shared-components


📝 Commits (1)

  • 2ab7969 refactor: extract common components into UI package

📊 Changes

50 files changed (+113493 additions, -926 deletions)

View changed files

📝 apps/marketing/package.json (+3 -2)
apps/marketing/public/pdf.worker.min.js (+56611 -0)
📝 apps/marketing/src/components/(marketing)/widget.tsx (+1 -1)
apps/marketing/src/components/signature-pad/signature-pad.tsx (+0 -212)
📝 apps/marketing/tsconfig.json (+4 -12)
📝 apps/web/package.json (+2 -2)
apps/web/public/pdf.worker.min.js (+56611 -0)
📝 apps/web/src/app/(dashboard)/dashboard/upload-document.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx (+89 -4)
📝 apps/web/src/app/(dashboard)/documents/[id]/loadable-pdf-card.tsx (+3 -18)
📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+1 -2)
📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+2 -3)
📝 apps/web/src/app/(signing)/sign/[token]/signature-field.tsx (+1 -2)
apps/web/src/components/(dashboard)/pdf-viewer/lazy-pdf-viewer.tsx (+0 -19)
📝 apps/web/src/components/(marketing)/widget.tsx (+1 -1)
📝 apps/web/src/components/forms/edit-document/add-fields.action.ts (+1 -2)
📝 apps/web/src/components/forms/edit-document/add-signers.action.ts (+1 -2)
📝 apps/web/src/components/forms/edit-document/add-subject.action.ts (+1 -2)
📝 apps/web/src/components/forms/profile.tsx (+1 -1)
📝 apps/web/src/components/forms/signup.tsx (+1 -2)

...and 30 more files

📄 Description

Extracted common components such as the signature pad, PDFs and document flow to the shared UI package in preparation for single player mode.

Refactored EditDocumentForm... components into DocumentFlowForm... components.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/293 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 8/23/2023 **Status:** ✅ Merged **Merged:** 8/23/2023 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `feat/refresh` ← **Head:** `feat/refactor-shared-components` --- ### 📝 Commits (1) - [`2ab7969`](https://github.com/documenso/documenso/commit/2ab796910efa41ea100ccb02b64f79f6f0b3f225) refactor: extract common components into UI package ### 📊 Changes **50 files changed** (+113493 additions, -926 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/package.json` (+3 -2) ➕ `apps/marketing/public/pdf.worker.min.js` (+56611 -0) 📝 `apps/marketing/src/components/(marketing)/widget.tsx` (+1 -1) ➖ `apps/marketing/src/components/signature-pad/signature-pad.tsx` (+0 -212) 📝 `apps/marketing/tsconfig.json` (+4 -12) 📝 `apps/web/package.json` (+2 -2) ➕ `apps/web/public/pdf.worker.min.js` (+56611 -0) 📝 `apps/web/src/app/(dashboard)/dashboard/upload-document.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx` (+89 -4) 📝 `apps/web/src/app/(dashboard)/documents/[id]/loadable-pdf-card.tsx` (+3 -18) 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+1 -2) 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+2 -3) 📝 `apps/web/src/app/(signing)/sign/[token]/signature-field.tsx` (+1 -2) ➖ `apps/web/src/components/(dashboard)/pdf-viewer/lazy-pdf-viewer.tsx` (+0 -19) 📝 `apps/web/src/components/(marketing)/widget.tsx` (+1 -1) 📝 `apps/web/src/components/forms/edit-document/add-fields.action.ts` (+1 -2) 📝 `apps/web/src/components/forms/edit-document/add-signers.action.ts` (+1 -2) 📝 `apps/web/src/components/forms/edit-document/add-subject.action.ts` (+1 -2) 📝 `apps/web/src/components/forms/profile.tsx` (+1 -1) 📝 `apps/web/src/components/forms/signup.tsx` (+1 -2) _...and 30 more files_ </details> ### 📄 Description Extracted common components such as the signature pad, PDFs and document flow to the shared UI package in preparation for single player mode. Refactored `EditDocumentForm...` components into `DocumentFlowForm...` components. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:30:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#854
No description provided.