[PR #256] [MERGED] Add husky & lint staged #827

Closed
opened 2026-02-26 19:30:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/256
Author: @nsylke
Created: 8/14/2023
Status: Merged
Merged: 8/17/2023
Merged by: @Mythie

Base: feat/refreshHead: nsylke-patch-2


📝 Commits (5)

  • f0c607d add husky and lint-staged to ensure commits are formatted
  • ba25ea1 refactor: use lint-staged.config.cjs as configuration for lint-staged
  • 6017d35 refactor: future proofing the prettier/lint-staged for js/ts filetypes
  • 10e3924 Merge branch 'feat/refresh' into nsylke-patch-2
  • 8038f3a fix: used wrong lockfile version when resolving conflicts

📊 Changes

5 files changed (+525 additions, -2 deletions)

View changed files

.husky/pre-commit (+4 -0)
📝 docker/Dockerfile (+4 -1)
lint-staged.config.cjs (+3 -0)
📝 package-lock.json (+510 -0)
📝 package.json (+4 -1)

📄 Description

I didn't noticed an issue for this yet, but I did read the blog post about adding it - so this PR implements husky & lint-staged to ensure all future commits are formatted. There are a few ways of configuring lint-staged, I just took the straightforward approach, happy to change it - if preferred.

Additionally, I modified the Dockerfile to disable husky from being installed. You'll see something along the lines of this in the docker build logs when installing dependencies, indicating its been disabled.

. prepare$ husky install
. prepare: husky - HUSKY env variable is set to 0, skipping install
. prepare: Done

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/256 **Author:** [@nsylke](https://github.com/nsylke) **Created:** 8/14/2023 **Status:** ✅ Merged **Merged:** 8/17/2023 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `feat/refresh` ← **Head:** `nsylke-patch-2` --- ### 📝 Commits (5) - [`f0c607d`](https://github.com/documenso/documenso/commit/f0c607d87a7c7e20004285a6ae98c4cc062a544c) add husky and lint-staged to ensure commits are formatted - [`ba25ea1`](https://github.com/documenso/documenso/commit/ba25ea13705e8a22e0552b8f4bded15096853abd) refactor: use lint-staged.config.cjs as configuration for lint-staged - [`6017d35`](https://github.com/documenso/documenso/commit/6017d35cfd573094503a1b91353f534f58d608e8) refactor: future proofing the prettier/lint-staged for js/ts filetypes - [`10e3924`](https://github.com/documenso/documenso/commit/10e39246ce0fda059eb6f5819cb3a9b1e10dfc1d) Merge branch 'feat/refresh' into nsylke-patch-2 - [`8038f3a`](https://github.com/documenso/documenso/commit/8038f3ad0087e2b3e0fda54b4b658ec569af4480) fix: used wrong lockfile version when resolving conflicts ### 📊 Changes **5 files changed** (+525 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `.husky/pre-commit` (+4 -0) 📝 `docker/Dockerfile` (+4 -1) ➕ `lint-staged.config.cjs` (+3 -0) 📝 `package-lock.json` (+510 -0) 📝 `package.json` (+4 -1) </details> ### 📄 Description I didn't noticed an issue for this yet, but I did read the blog post about adding it - so this PR implements husky & lint-staged to ensure all future commits are formatted. There are a few ways of configuring lint-staged, I just took the straightforward approach, happy to change it - if preferred. Additionally, I modified the Dockerfile to disable husky from being installed. You'll see something along the lines of this in the docker build logs when installing dependencies, indicating its been disabled. ```bash . prepare$ husky install . prepare: husky - HUSKY env variable is set to 0, skipping install . prepare: Done ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:30:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#827
No description provided.