[PR #140] [MERGED] fix: debounce display of signing canvas #748

New issue

Closed

opened 2026-02-26 18:48:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:48:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/140
Author: @Mythie
Created: 4/21/2023
Status: ✅ Merged
Merged: 4/28/2023
Merged by: @ElTimuro

Base: main ← Head: feat/DOC-210-sign-dialog-broken-on-second-opening

📝 Commits (3)

4dcb0a6 fix: debounce display of signing canvas
d0f9625 Merge branch 'main' into feat/DOC-210-sign-dialog-broken-on-second-opening
108614b Merge branch 'main' into feat/DOC-210-sign-dialog-broken-on-second-opening

📊 Changes

2 files changed (+37 additions, -13 deletions)

View changed files

📝 apps/web/components/editor/signature-dialog.tsx (+19 -13)
➕ apps/web/hooks/use-debounced-value.ts (+18 -0)

📄 Description

Debounces the display of the signing canvas to avoid situations where the canvas renders to 2px due to rendering while a transition is being performed.

Video of the change can be found below:
https://www.loom.com/share/69f3f0b6374247098bb61cc4ce789e81

Closes #43

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/140 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 4/21/2023 **Status:** ✅ Merged **Merged:** 4/28/2023 **Merged by:** [@ElTimuro](https://github.com/ElTimuro) **Base:** `main` ← **Head:** `feat/DOC-210-sign-dialog-broken-on-second-opening` --- ### 📝 Commits (3) - [`4dcb0a6`](https://github.com/documenso/documenso/commit/4dcb0a684dba52951a2eb241909165d4fa66ab5d) fix: debounce display of signing canvas - [`d0f9625`](https://github.com/documenso/documenso/commit/d0f962598ccab6cdd7610adf324de4a411c3b9a4) Merge branch 'main' into feat/DOC-210-sign-dialog-broken-on-second-opening - [`108614b`](https://github.com/documenso/documenso/commit/108614bf4686d2903b592be04cb6303aa24d8578) Merge branch 'main' into feat/DOC-210-sign-dialog-broken-on-second-opening ### 📊 Changes **2 files changed** (+37 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/editor/signature-dialog.tsx` (+19 -13) ➕ `apps/web/hooks/use-debounced-value.ts` (+18 -0) </details> ### 📄 Description Debounces the display of the signing canvas to avoid situations where the canvas renders to 2px due to rendering while a transition is being performed. Video of the change can be found below: https://www.loom.com/share/69f3f0b6374247098bb61cc4ce789e81 Closes #43 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 18:48:45 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#748

No description provided.

Rows
Columns