[PR #141] [MERGED] fix: date field appears for all recipients #747

Closed
opened 2026-02-26 18:48:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/141
Author: @Mythie
Created: 4/21/2023
Status: Merged
Merged: 4/28/2023
Merged by: @ElTimuro

Base: mainHead: fix/DOC-214-date-field-appears-for-all-recipients


📝 Commits (3)

  • 81fd9ff fix: date field appears for all recipients
  • a6171ec Merge branch 'main' into fix/DOC-214-date-field-appears-for-all-recipients
  • 82139f6 Merge branch 'main' into fix/DOC-214-date-field-appears-for-all-recipients

📊 Changes

3 files changed (+9 additions, -1 deletions)

View changed files

📝 apps/web/pages/api/documents/[id]/sign.ts (+6 -1)
packages/prisma/migrations/20230421134018_doc_214_add_signed_at_field/migration.sql (+2 -0)
📝 packages/prisma/schema.prisma (+1 -0)

📄 Description

Updates the signing endpoint to only apply changes to the Date field for the current signer. This is made possible through the addition of the signedAt column within the database.

Resolves the issue with one signer filling the date for all recipients and also ensures that the date of signing on a document won't always be todays date after each recipient has signed.

Closes #48


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/141 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 4/21/2023 **Status:** ✅ Merged **Merged:** 4/28/2023 **Merged by:** [@ElTimuro](https://github.com/ElTimuro) **Base:** `main` ← **Head:** `fix/DOC-214-date-field-appears-for-all-recipients` --- ### 📝 Commits (3) - [`81fd9ff`](https://github.com/documenso/documenso/commit/81fd9ff7498df8306cf38d186f4ab6f5c253917c) fix: date field appears for all recipients - [`a6171ec`](https://github.com/documenso/documenso/commit/a6171ec4f38f4441c502dbc5e0fdaaad7cc13db0) Merge branch 'main' into fix/DOC-214-date-field-appears-for-all-recipients - [`82139f6`](https://github.com/documenso/documenso/commit/82139f6b2d9f08e97f65b09d9d1df8abe13353f1) Merge branch 'main' into fix/DOC-214-date-field-appears-for-all-recipients ### 📊 Changes **3 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/pages/api/documents/[id]/sign.ts` (+6 -1) ➕ `packages/prisma/migrations/20230421134018_doc_214_add_signed_at_field/migration.sql` (+2 -0) 📝 `packages/prisma/schema.prisma` (+1 -0) </details> ### 📄 Description Updates the signing endpoint to only apply changes to the Date field for the current signer. This is made possible through the addition of the `signedAt` column within the database. Resolves the issue with one signer filling the date for all recipients and also ensures that the date of signing on a document won't always be todays date after each recipient has signed. Closes #48 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 18:48:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#747
No description provided.