[PR #134] [MERGED] Toast error for invalid email #741

Closed
opened 2026-02-26 18:48:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/134
Author: @sauravgurhale
Created: 4/16/2023
Status: Merged
Merged: 4/19/2023
Merged by: @Mythie

Base: mainHead: bugfix-#71/invalid-email-hint


📝 Commits (2)

  • 80d26ad add toast error for invalid email
  • 70ea3ce fix: improve types

📊 Changes

1 file changed (+11 additions, -6 deletions)

View changed files

📝 apps/web/pages/documents/[id]/recipients.tsx (+11 -6)

📄 Description

As suggested, this PR adds a user feedback, when any of entered email(s) is invalid.

Preview
Entered email is invalid
- When user clicks on Send, a toast error appears (preventing the dialog from opening)
image

Fixes #71


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/134 **Author:** [@sauravgurhale](https://github.com/sauravgurhale) **Created:** 4/16/2023 **Status:** ✅ Merged **Merged:** 4/19/2023 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `bugfix-#71/invalid-email-hint` --- ### 📝 Commits (2) - [`80d26ad`](https://github.com/documenso/documenso/commit/80d26adf9c131cbe5ccd5b63a60a99586cc17f76) add toast error for invalid email - [`70ea3ce`](https://github.com/documenso/documenso/commit/70ea3ceaf3952b32d1ee21e6a3c3c1efe06dad2e) fix: improve types ### 📊 Changes **1 file changed** (+11 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/pages/documents/[id]/recipients.tsx` (+11 -6) </details> ### 📄 Description As suggested, this PR adds a user feedback, when any of entered email(s) is invalid. |Preview| |--| |Entered email is invalid <br> - When user clicks on `Send`, a toast error appears (preventing the dialog from opening) | |![image](https://user-images.githubusercontent.com/65268462/232339632-077961f2-6f96-4063-8fa1-850a0ff20dd9.png) Fixes #71 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 18:48:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#741
No description provided.