starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[GH-ISSUE #277] For Every add Signer without a email, we are storing empty values in DB #74

New issue

Closed

opened 2026-02-26 18:45:15 +03:00 by kerem · 5 comments

kerem commented

2026-02-26 18:45:15 +03:00

Owner

Originally created by @yashug on GitHub (Aug 18, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/277

Whenever an additional signer is added without an associated email, we're currently storing empty values in the database. This is causing issues with unidentified emails and subsequently displaying an incorrect count of recipients

Originally created by @yashug on GitHub (Aug 18, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/277 Whenever an additional signer is added without an associated email, we're currently storing empty values in the database. This is causing issues with unidentified emails and subsequently displaying an incorrect count of recipients ![Screenshot 2023-08-18 at 6 38 40 PM](https://github.com/documenso/documenso/assets/14201280/a7d7b90b-5f6f-4587-8dbf-a923cda801b5) ![Screenshot 2023-08-18 at 6 41 01 PM](https://github.com/documenso/documenso/assets/14201280/d828403d-203a-41ea-9501-12c8186f8090)

kerem closed this issue

2026-02-26 18:45:15 +03:00

kerem commented

2026-02-26 18:45:15 +03:00

Author

Owner

@diogoribeirodev commented on GitHub (Aug 18, 2023):

This easy to fix on the displaying part, for that specific display changing this
{props?.recipients.map( (recipient: any) =><Listbox.Option></Listbox.Option>)}

to this:
{props?.recipients.map( (recipient: any) =>recipient?.email?.length > 1 && (<Listbox.Option></Listbox.Option>))}

fixes the issue, but it shouldnt even be allowed to save empty signers in first place! Can anyone from the team suggest a change, we can either fix the displaying errors with an if condition( check for empy emails ) or we can change the way the signers are saved in the db.

@diogoribeirodev commented on GitHub (Aug 18, 2023): This easy to fix on the displaying part, for that specific display changing this `{props?.recipients.map( (recipient: any) =><Listbox.Option></Listbox.Option>)} ` to this: `{props?.recipients.map( (recipient: any) =>recipient?.email?.length > 1 && (<Listbox.Option></Listbox.Option>))} ` fixes the issue, but it shouldnt even be allowed to save empty signers in first place! Can anyone from the team suggest a change, we can either fix the displaying errors with an if condition( check for empy emails ) or we can change the way the signers are saved in the db.

kerem commented

2026-02-26 18:45:15 +03:00

Author

Owner

@adithyaakrishna commented on GitHub (Aug 19, 2023):

@Diogovski IMO this wouldn't be the right way to fix it. We can use isEmpty condition with a ternary operator

@adithyaakrishna commented on GitHub (Aug 19, 2023): @Diogovski IMO this wouldn't be the right way to fix it. We can use isEmpty condition with a ternary operator

kerem commented

2026-02-26 18:45:15 +03:00

Author

Owner

@vinaybadgujar102 commented on GitHub (Sep 6, 2023):

I can work on this issue

@vinaybadgujar102 commented on GitHub (Sep 6, 2023): I can work on this issue

kerem commented

2026-02-26 18:45:15 +03:00

Author

Owner

@Hallidayo commented on GitHub (Sep 30, 2023):

Hi all, seems this issue is fixed in the feat/refresh branch

@Hallidayo commented on GitHub (Sep 30, 2023): Hi all, seems this issue is fixed in the `feat/refresh` branch

kerem commented

2026-02-26 18:45:15 +03:00

Author

Owner

@Mythie commented on GitHub (Nov 3, 2023):

Closing as this has been fixed in 1.0 as mentioned above 😄

@Mythie commented on GitHub (Nov 3, 2023): Closing as this has been fixed in 1.0 as mentioned above 😄

kerem referenced this issue

2026-02-26 18:48:41 +03:00

[PR #74] [MERGED] chore: optimise depedency tree #734

kerem referenced this issue

2026-02-26 18:48:42 +03:00

[PR #77] [CLOSED] Support Next.js standalone builds. #736

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#74

No description provided.

Rows
Columns