[PR #70] [CLOSED] Delete empty recipient fields #731

New issue

Closed

opened 2026-02-26 18:48:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:48:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/70
Author: @sauravgurhale
Created: 4/11/2023
Status: ❌ Closed

Base: main ← Head: bugfix/issue#39/empty-recipients

📝 Commits (1)

8f9eb1f delete empty fields

📊 Changes

1 file changed (+15 additions, -0 deletions)

View changed files

📝 apps/web/pages/documents/[id]/recipients.tsx (+15 -0)

📄 Description

	comments
`issue`	- Application allows for sending signing requests to empty recipients - An empty recipient record is added to the `Recipient` in db. (at first I thought this was unnecessary, but the implementation of useFieldArray forces us to so) - This is why the status is `pending` even after completion
`fix`	- A possible workaround is deleting the empty records (from db and fieldArray) when user clicks `Send`.
preview	https://www.loom.com/share/1eadbf82efcb4de2ac0b0e00b62cf01f

I have opened another related issue here #69

Fixes #39

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/70 **Author:** [@sauravgurhale](https://github.com/sauravgurhale) **Created:** 4/11/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bugfix/issue#39/empty-recipients` --- ### 📝 Commits (1) - [`8f9eb1f`](https://github.com/documenso/documenso/commit/8f9eb1fbdade1cc9cee18714329246265dd8f227) delete empty fields ### 📊 Changes **1 file changed** (+15 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/pages/documents/[id]/recipients.tsx` (+15 -0) </details> ### 📄 Description ||comments| |--|--| |`issue`| - Application allows for sending signing requests to empty recipients <br> - An empty recipient record is added to the `Recipient` in db. (at first I thought this was unnecessary, but the implementation of [useFieldArray](https://react-hook-form.com/api/usefieldarray/) forces us to so) <br> - This is why the status is `pending` even after completion| |`fix`| - A possible workaround is deleting the empty records (from db and fieldArray) when user clicks `Send`. | |preview| https://www.loom.com/share/1eadbf82efcb4de2ac0b0e00b62cf01f| I have opened another related issue here #69 Fixes #39 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 18:48:41 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#731

No description provided.

Rows
Columns