starred/documenso

Fork

You've already forked documenso

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

Code Issues 248 Projects Releases 10 Packages Wiki Activity

[PR #35] [CLOSED] Assorted updates from code review #723

New issue

Closed

opened 2026-02-26 18:48:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:48:39 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/35
Author: @Mythie
Created: 4/4/2023
Status: ❌ Closed

Base: main ← Head: fix/assorted-updates-from-review

📝 Commits (10+)

fe4c3d4 fix: recipient selector would only show selected recipient
37c2031 docs: add inbucket instructions
6ab88de fix: add status filters to url state
7f81eb5 fix: add stronger typing and remove use effect from recipient and field type selection
1a95481 fix: remove usages of any and create dirtClone util
0e4c10b fix: make getUserFromToken ssr and api compatible
169987b fix: remove usages of any on dashboard and tidy code
b7cfd57 fix: improve typings of pdf signer and signature dialog
5d9d38c fix: assorted tidying
71f6f5e fix: don't update unknown property for now

📊 Changes

22 files changed (+362 additions, -205 deletions)

View changed files

📝 README.md (+9 -0)
📝 apps/web/components/editor/editable-field.tsx (+1 -3)
📝 apps/web/components/editor/field-type-selector.tsx (+38 -25)
📝 apps/web/components/editor/pdf-editor.tsx (+20 -15)
📝 apps/web/components/editor/pdf-signer.tsx (+46 -25)
📝 apps/web/components/editor/recipient-selector.tsx (+22 -12)
📝 apps/web/components/editor/signature-dialog.tsx (+43 -18)
📝 apps/web/components/login.tsx (+6 -2)
📝 apps/web/components/logo.tsx (+7 -2)
📝 apps/web/pages/dashboard.tsx (+43 -48)
📝 apps/web/pages/documents.tsx (+59 -28)
📝 apps/web/pages/documents/[id]/index.tsx (+3 -3)
📝 apps/web/pages/documents/[id]/recipients.tsx (+2 -1)
📝 apps/web/pages/documents/[id]/sign.tsx (+5 -5)
📝 apps/web/pages/documents/[id]/signed.tsx (+5 -4)
📝 apps/web/pages/login.tsx (+6 -3)
➕ apps/web/process-env.d.ts (+23 -0)
📝 apps/web/tsconfig.json (+1 -0)
📝 packages/lib/api/signDocument.ts (+0 -1)
➕ packages/lib/dirtyClone.ts (+3 -0)

...and 2 more files

📄 Description

On 05/04/2023, we had a review session of Documenso codebase where we discussed various items. These are the items we covered:

Update documentation to reflect seeding and migrating the database
Include a seed for a document with a signable pdf?
Add instructions for SMTP (inbucket)
Signed users are duplicated (bug)
Changing filter does not update url state
- Tidy up document.tsx
Prop types are needed in more places
- More prop types are needed in more places
Some useEffects can be swapped for event handlers
- There is still the ones in documents.tsx but they are load bearing and should be approached more carefully.
api toasts to be moved to caller [Discussed reasoning and will not move for now]
- sendSigningRequests
- deleteRecipient
- signDocument
Double check getUserFromToken, specifically the next-auth getToken
Check if we still need a local copy of node-signpdf in addDigitalSignature
- The PR was merged only last month, currently have the latest version installed already and just need to work on swapping it out.
More useEffect shenanigans

This PR contains individual commits for each of these changes to facilitate an easier review process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/35 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 4/4/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/assorted-updates-from-review` --- ### 📝 Commits (10+) - [`fe4c3d4`](https://github.com/documenso/documenso/commit/fe4c3d4a5ff1412929d4d9286d08ac7a052f721c) fix: recipient selector would only show selected recipient - [`37c2031`](https://github.com/documenso/documenso/commit/37c2031b5cba1fff4b4e91d4f7217e4ff982dfcd) docs: add inbucket instructions - [`6ab88de`](https://github.com/documenso/documenso/commit/6ab88de4000632a84b2f1a57abe6b4e52cef852c) fix: add status filters to url state - [`7f81eb5`](https://github.com/documenso/documenso/commit/7f81eb5e29a2ce0ba54e64780371ba3ed31337c6) fix: add stronger typing and remove use effect from recipient and field type selection - [`1a95481`](https://github.com/documenso/documenso/commit/1a954818aab0d3affb6ee14ec14590477bdd2a5c) fix: remove usages of any and create dirtClone util - [`0e4c10b`](https://github.com/documenso/documenso/commit/0e4c10b346ae4e33ffaa85a8589ef13969a80d81) fix: make getUserFromToken ssr and api compatible - [`169987b`](https://github.com/documenso/documenso/commit/169987b4f047d4ec8ba385a74d561556268112ab) fix: remove usages of any on dashboard and tidy code - [`b7cfd57`](https://github.com/documenso/documenso/commit/b7cfd573c67b7ef79da883f8f95d7781bac68d95) fix: improve typings of pdf signer and signature dialog - [`5d9d38c`](https://github.com/documenso/documenso/commit/5d9d38cb68cf6f3f0c4ba9331fd638db8555465a) fix: assorted tidying - [`71f6f5e`](https://github.com/documenso/documenso/commit/71f6f5e6387e891d06cf776ae4077326e98d2e80) fix: don't update unknown property for now ### 📊 Changes **22 files changed** (+362 additions, -205 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+9 -0) 📝 `apps/web/components/editor/editable-field.tsx` (+1 -3) 📝 `apps/web/components/editor/field-type-selector.tsx` (+38 -25) 📝 `apps/web/components/editor/pdf-editor.tsx` (+20 -15) 📝 `apps/web/components/editor/pdf-signer.tsx` (+46 -25) 📝 `apps/web/components/editor/recipient-selector.tsx` (+22 -12) 📝 `apps/web/components/editor/signature-dialog.tsx` (+43 -18) 📝 `apps/web/components/login.tsx` (+6 -2) 📝 `apps/web/components/logo.tsx` (+7 -2) 📝 `apps/web/pages/dashboard.tsx` (+43 -48) 📝 `apps/web/pages/documents.tsx` (+59 -28) 📝 `apps/web/pages/documents/[id]/index.tsx` (+3 -3) 📝 `apps/web/pages/documents/[id]/recipients.tsx` (+2 -1) 📝 `apps/web/pages/documents/[id]/sign.tsx` (+5 -5) 📝 `apps/web/pages/documents/[id]/signed.tsx` (+5 -4) 📝 `apps/web/pages/login.tsx` (+6 -3) ➕ `apps/web/process-env.d.ts` (+23 -0) 📝 `apps/web/tsconfig.json` (+1 -0) 📝 `packages/lib/api/signDocument.ts` (+0 -1) ➕ `packages/lib/dirtyClone.ts` (+3 -0) _...and 2 more files_ </details> ### 📄 Description On 05/04/2023, we had a review session of Documenso codebase where we discussed various items. These are the items we covered: - [x] Update documentation to reflect seeding and migrating the database - [x] Include a seed for a document with a signable pdf? - [x] Add instructions for SMTP (inbucket) - [x] Signed users are duplicated (bug) - [x] Changing filter does not update url state - [ ] Tidy up `document.tsx` - [x] Prop types are needed in more places - [ ] More prop types are needed in more places - [x] Some useEffects can be swapped for event handlers - [ ] There is still the ones in `documents.tsx` but they are load bearing and should be approached more carefully. - [x] api toasts to be moved to caller [Discussed reasoning and will not move for now] - sendSigningRequests - deleteRecipient - signDocument - [x] Double check getUserFromToken, specifically the next-auth getToken - [ ] Check if we still need a local copy of `node-signpdf` in `addDigitalSignature` - [ ] The PR was merged only last month, currently have the latest version installed already and just need to work on swapping it out. - [x] More useEffect shenanigans This PR contains individual commits for each of these changes to facilitate an easier review process. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 18:48:39 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:32:00 +03:00

[PR #723] [CLOSED] feat : Document Thumbnails #1139

No Branch/Tag specified

main

chore/translations

feat/signing-required-field-colors

feat/add-field-overflow-settings

chore/extract-translations

release

feat/public-completed-document-access

feat/bulk-download

docs/signing-reminders

feat/document-file-conversion

feat/prefetch-intent-navigation-links

fix/lint-project

fix/replace-linter-with-biome

fix/security-improvements

perf/dynamic-import-posthog

deps/vite-8

chore/migrate-eslint-prettier-to-oxlint-oxfmt

chore/migrate-to-pnpm

feat/add-pdf-image-renderer

feat/add-embed-v2

fix/extract-emails

feat/table-toolbar-filters

copilot/sub-pr-2478

fix/recipients-send-500

feat/external-2fa-codes

feat/protect-signing-urls

fix/checkbox-checked-values

duncan/legacy-api-endpoints

chore/block-po-files-locally

fix/default-embed-v2-document-rejection-to-false

fix/fields-dialog-title-description

copilot/sub-pr-2323

copilot/sub-pr-2267

exp/autoplace-fields

chore/server-hostname-config

fix/template-add-signers

fix/add-field-drag-drop-colors

fix/envelope-updates

feat/allow-formdata

archive/1.13.2

copilot/add-billing-section-account-page

fix/field-coordinate-bounds

feat/update-user-via-admin-dashboard

feat/expiry-links

feat/team-dashboard

feat/change-radio-direction

feat/admin-create-user-with-org

archive/v1.12.11

feat/envelopes-polish

feat/add-attachments-reworked

fix/font-size-fields

feat/improve-resend-dialog

fix/download-certificate-audit-log-safari

fix/duplicate-document-by-id

feat/document-table-filters

fix/template-migration

exp/effect

fix/migrate-template-metadata

exp/keyboard-signature

feat/document-2fa-redo

feat/add-attachments

feat/billing-redirect-flow

fix/add-api-logging

fix/duplicate-document-template-review

feat/handle-redirectto-param

feat/document-processing-status-indicator

feat/customize-doc-audit-log-certificate

feat/document-2fa

feat/organisations-backup-pls

feat/audit-logs-on-completed-document

chore/webhook-trigger-multiselect

exp/bg

chore/single-signer-wording

fix/template-uploading

feat/bin-tab

fix/staging-test

feat/rr7

squish/rr7

archive/nextjs

power-signer

fix/field-placements

fix/team-member-invites

fix/checkbox-field-bugs

fix/leaderboard-query

fix/zapier-list-documents-endpoint

feat/dictate-signers

feat/allow-same-signer-email-multiple-times

wip/rr7-next

experiment/self-sign

fix/oidc-login-error

feat/document-qrcode

feat/mau

feat/copy-links-audit-logs

chore/december-dep-upgrades

wip/rr7

wip/rr7-auth-package

wip/rr7-better-auth-demo

experiment/what-if-user-ids-were-strings-instead-of-numbers

fix/refactor-api-routes

feat/add-owner-completed-email-setting

fix/embed-whitelabel-colors

feat/delete-archive

fun/sign-with-nose

expiry-links

chore/openpage-viral-metrics

fix/sitemap

feat/signing-reminder

feat/automated-fields-signature

feat/add-polish-translations

staging

fix/open-page

openpage-api-deploy

feat/pulumi

chore/angular-embed-docs

exp/next-15

chore/select-signer

feat/save-data-on-blur

feat/save-recipients-on-blur

feat/signature-color

feat/team-email-template

chore/documenso-url

chore/add-ctas

fix/docker-setup-and-documentation

fix/document-creation-timezone

feat/telemetry

feat/integration-animation

fix/render-deployment

feat/publicProfile

feat/redirect-templates

feat/passkey-dialog

fix/refactor-use-template

chore/resend-onUpdate

chore/subject-onBlur

fix/demo-trpc-duration

fix/self-signer-custom-email-message

fix/benchmark

feat/add-myself-as-signer-temp

feat/checkbox-type

feat/update-marketing-header

experiment/queue

feat/error-demo

feat/add-document-auth-options

feat/document-2fa-test

chore/status-widget

open-page-restructure

feat/document-passkey-test

chore/form-reset

fix/neon-db-migration-test

feat/public-profile

feat/launch-week-content

webhooks_plus_api

exp/custom-field-labels

feat/accept-text-signature

feat/document-version-history

fix/delete-recipient-owners

fix/whitespace-title

feat/refresh

exp/million

feat/doc-comments

ElTimuro-patch-1

feat/teams-slugify

pr/537

date-format-setting

exp/millionjs

feat/runtime-env

chore/next-14

feat/chat-with-documents

feat/plan-limits

fix/467-bugsafari-only-unable-to-copy-document-sharing-link

feat/admin-ui-manage-instance

feat/stripe-free-tier

fix/cascade-delete-share-links

feat/marketing-share-document

feat/single-player-mode-polish

feat/next-13-5-3

chore/github-templates

docs/render-deploy

chore/code-of-conduct

chore/team

feat/add-e2e-testing

docs/minor-readme-updatess

docs/dx

feat-early-adopters

feat/open-early-adopters

fix/432-signee-doc-version-doesnt-have-sticky-signing-area

fix/446-cancel-cta-does-nothing-when-a-signer-opens-the-document

fix/445-signer-name-not-persisting

feat/resend-transport

fix/incorrect-completed-stats

feat/update-email-templates

feat/mania

feat/copy-or-tweet

feat/add-design-system-page

feat/single-player-mode

feat/completed-share-link

feat/designsystem

feat/send-email

feat/custom-emails

blog/upcoming-blog-post

feat/single-player-mode-test

feat/reset-password

blog/selfhosting-blog-post

feat/redirect-signed-document

fix/og-description

feat/universal-upload

chore/readme

chore/blogposts

fix/building-documenso-description

feat/admin-ui-metrics

feat/avatar-fallback

feat/templates

feat/blog-post-next

fix/hide-user-selection

feat/disable-sign

feat/marketing-mobile-nav

chore/remove-console-log-warn

feat/add-email-field

fix/redirect-signin-to-dashboard

feat/blog-og-image

feat/redirect-on-send

feat/billing-page

feat/profile-password-form

fix/signature-color-dark-mode

feat/inbox

feat/promise-safety

readme

chore/reduce-refetch-time

feat/update-document-flow

feat/refactor-shared-components

feat/feature-flag

feat/document-authoring

feat/pie-chart-legend

feat/open-page

docs/add-gitpod-setup

docs/add-render-deploy

docs-coventional-commits

feat/table-actions

minor/updates-google-auth-refresh

feat/add-document-animation

feat/new-email-template

feat/password-reset

fix/send-error-double-send

fix/improve-stripe-webhook-endpoint

feat/support-custom-cert-paths

feat/DOC-170-add-name-field

fix/improve-general-styling

feat/DOC-210-sign-dialog-broken-on-second-opening

bugfix-#71/invalid-email-hint

chore/optimise-deps

test-pr

v2.9.1

v2.9.0

v2.8.1

v2.8.0

v2.7.1

v2.7.0

v2.6.1

v2.6.0

v2.5.1

v2.5.0

v2.4.0

v2.3.2

v2.3.1

v2.3.0

v2.2.8

v2.2.7

v2.2.6

v2.2.5

v2.2.4

v2.2.3

v2.2.2

v2.2.1

v2.2.0

v2.1.0

v2.0.14

v2.0.13

v2.0.12

v2.0.11

v2.0.10

v2.0.9

v2.0.8

v2.0.7

v2.0.6

v2.0.5

v2.0.4

v2.0.3

v2.0.2

v2.0.1

v2.0.0

v1.13.2

v1.13.1

v1.13.0

v1.12.10

v1.12.9

v1.12.8

v1.12.7

v1.12.6

v1.12.5

v1.12.4

v1.12.3

v1.12.2-rc.6

v1.12.2-rc.5

v1.12.2-rc.4

v1.12.2-rc.3

v1.12.2-rc.2

v1.12.2-rc.1

v1.12.2-rc.0

v1.12.1

v1.12.0

v1.12.0-rc.8

v1.12.0-rc.7

v1.12.0-rc.6

v1.12.0-rc.5

v1.12.0-rc.4

v1.12.0-rc.3

v1.12.0-rc.2

v1.12.0-rc.1

v1.12.0-rc.0

v1.11.1

v1.11.0

v1.10.3

v1.10.2

v1.10.1

v1.10.0

v1.10.0-rc.5

v1.10.0-rc.4

v1.10.0-rc.3

v1.10.0-rc.2

v1.10.0-rc.1

v1.10.0-rc.0

v1.9.1-rc.9

v1.9.1

v1.9.1-rc.8

v1.9.1-rc.7

v1.9.1-rc.6

v1.9.1-rc.5

v1.9.1-rc.4

v1.9.1-rc.3

v1.9.1-rc.2

v1.9.1-rc.1

v1.9.1-rc.0

v1.9.0

v1.9.0-rc.12

v1.9.0-rc.11

v1.9.0-rc.10

v1.9.0-rc.9

v1.9.0-rc.8

v1.9.0-rc.7

v1.9.0-rc.6

v1.9.0-rc.5

final-marketing-release

v1.9.0-rc.4

v1.9.0-rc.3

v1.9.0-rc.2

v1.9.0-rc.1

v1.9.0-rc.0

v1.8.1

v1.8.1-rc.9

v1.8.1-rc.8

v1.8.1-rc.7

v1.8.1-rc.6

v1.8.1-rc.5

v1.8.1-rc.4

v1.8.1-rc.3

v1.8.1-rc.2

v1.8.1-rc.1

v1.8.1-rc.0

v1.8.0-rc.4

v1.8.0

v1.8.0-rc.3

v1.8.0-rc.2

v1.8.0-rc.1

v1.8.0-rc.0

v1.7.2

v1.7.2-rc.4

v1.7.2-rc.3

v1.7.2-rc.2

v1.7.2-rc.1

v1.7.2-rc.0

v1.7.1-rc.3

v1.7.1

v1.7.1-rc.2

v1.7.1-rc.1

v1.7.1-rc.0

v1.7.0

v1.7.0-rc.5

v1.7.0-rc.4

v1.7.0-rc.3

v1.7.0-rc.2

v1.7.0-rc.1

v1.7.0-rc.0

v1.6.1

v1.6.1-rc.1

v1.6.1-rc.0

v1.6.0

v1.6.0-rc.3

v1.6.0-rc.2

v1.6.0-rc.1

v1.6.0-rc.0

v1.5.6

v1.5.6-rc.4

v1.5.6-rc.3

v1.5.6-rc.2

v1.5.6-rc.1

v1.5.6-rc.0

v1.5.5-rc.8

v1.5.5

v1.5.5-rc.7

v1.5.5-rc.6

v1.5.5-rc.5

v1.5.5-rc.4

v1.5.5-rc.3

v1.5.5-rc.2

v1.5.5-rc.1

v1.5.5-rc.0

v1.5.4-rc.5

v1.5.4

v1.5.4-rc.4

v1.5.4-rc.3

v1.5.4-rc.2

v1.5.4-rc.1

v1.5.4-rc.0

v1.5.3-rc.1

v1.5.3

v1.5.3-rc.0

v1.5.2-rc.8

v1.5.2

v1.5.2-rc.7

v1.5.2-rc.6

v1.5.2-rc.5

v1.5.2-rc.4

v1.5.2-rc.3

v1.5.2-rc.2

v1.5.2-rc.1

v1.5.2-rc.0

v1.5.1

v1.5.1-rc.0

v1.5.0-rc.6

v1.5.0

v1.5.0-rc.5

v1.5.0-rc.4

v1.5.0-rc.3

v1.5.0-rc.2

v1.5.0-rc.1

v1.5.0-rc.0

v1.4.0-rc.0

v1.4.0

v1.3.2-rc.0

v1.3.1-rc.2

v1.3.1

v1.3.1-rc.1

v1.3.1-rc.0

v1.3.0-rc.2

v1.3.0

v1.3.0-rc.1

v1.3.0-rc.0

v1.2.3

v1.2.2

v1.2.1

v1.2.0

v1.1

v1.0

v0.9

before-prettier

0.9-developer-preview

Labels

Clear labels

component: integrations

Mirrored from GitHub Pull Request

No labels

component: integrations

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#723

Reference in a new issue

Repository

starred/documenso

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns