starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[GH-ISSUE #2171] i18n: Missing pluralization in data-table-pagination.tsx #629

New issue

Closed

opened 2026-02-26 18:47:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:47:50 +03:00

Owner

Originally created by @mKoonrad on GitHub (Nov 11, 2025).
Original GitHub issue: https://github.com/documenso/documenso/issues/2171

Issue Description

Missing pluralization for
github.com/documenso/documenso@3d0e3c6e8e/packages/ui/primitives/data-table-pagination.tsx (L30-L33)
in data-table-pagination.tsx

In English, there is one singular and one plural form. In many other languages (like Polish) there are more plural forms (few and many). It prevents correct translation.

Steps to Reproduce

Go to any table that uses DataTablePagination (e.g., the documents list).
Select one item in the table.
Observe the text (e.g., 1 of 10 row(s) selected.).
Select multiple items.
Observe the text (e.g., 5 of 10 row(s) selected.).

Expected Behavior

String should use Lingui's plural component to correctly handle all pluralization forms based on the value of {table.getFilteredRowModel().rows.length}

Current Behavior

Grammatically incorrect message

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome

Version [e.g., 2.0.1]

v2.0.6

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @mKoonrad on GitHub (Nov 11, 2025). Original GitHub issue: https://github.com/documenso/documenso/issues/2171 ### Issue Description Missing pluralization for https://github.com/documenso/documenso/blob/3d0e3c6e8ea375df6b92d181caf1170f9bb398c6/packages/ui/primitives/data-table-pagination.tsx#L30-L33 in [data-table-pagination.tsx](https://github.com/documenso/documenso/blob/3d0e3c6e8ea375df6b92d181caf1170f9bb398c6/packages/ui/primitives/data-table-pagination.tsx) In English, there is one singular and one plural form. In many other languages (like Polish) there are more plural forms (few and many). It prevents correct translation. ### Steps to Reproduce 1. Go to any table that uses `DataTablePagination` (e.g., the documents list). 2. Select one item in the table. 3. Observe the text (e.g., `1 of 10 row(s) selected.`). 4. Select multiple items. 5. Observe the text (e.g., `5 of 10 row(s) selected.`). ### Expected Behavior String should use Lingui's plural component to correctly handle all pluralization forms based on the value of `{table.getFilteredRowModel().rows.length}` ### Current Behavior Grammatically incorrect message ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] Windows 11 ### Browser [e.g., Chrome, Firefox] Chrome ### Version [e.g., 2.0.1] v2.0.6 ### Please check the boxes that apply to this issue report. - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [ ] I have included any relevant screenshots. - [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [x] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:47:50 +03:00

closed this issue
added the
status: triage
label

kerem referenced this issue

2026-02-26 19:31:46 +03:00

[PR #629] [CLOSED] fix: document listing not updating after uploading #1086

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#629

No description provided.

Rows
Columns