starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[GH-ISSUE #2121] i18n: Recipient invitation messages are fragmented, preventing correct translation #614

New issue

Closed

opened 2026-02-26 18:47:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:47:47 +03:00

Owner

Originally created by @mKoonrad on GitHub (Oct 30, 2025).
Original GitHub issue: https://github.com/documenso/documenso/issues/2121

Issue Description

In the DocumentSigningPageViewV1.tsx file, sentences that informs the recipient who invited them to sign/view the document are split into multiple parts. The sender's information {senderName} {senderEmail} is rendered separately from the translatable string (e.g., <Trans>has invited you to sign this document</Trans>).

This fragmentation prevents translators from correctly adapting the sentence structure for their language. Many languages do not follow the English Subject-Verb-Object order and may need to place the sender's name at the end of the sentence or use a completely different grammatical structure (e.g., An invitation to sign was sent by {senderName}).

Steps to Reproduce

Open the file DocumentSigningPageViewV1.tsx
Observe messages rendered after line
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L194)
and
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L322)

Expected Behavior

The entire sentence should be wrapped in a single <Trans> component. Variables should be passed into the component to give translators full context and the flexibility to reorder the sentence elements.

Strings to fix:
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L197-L199)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L201)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L206-L208)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L210)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L215-L217)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L219)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L224-L226)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (L228)

Current Behavior

The sentences are fragmented.

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome

Version [e.g., 2.0.1]

v1.13.1

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @mKoonrad on GitHub (Oct 30, 2025). Original GitHub issue: https://github.com/documenso/documenso/issues/2121 ### Issue Description In the [DocumentSigningPageViewV1.tsx](https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx) file, sentences that informs the recipient who invited them to sign/view the document are split into multiple parts. The sender's information `{senderName} {senderEmail}` is rendered separately from the translatable string (e.g., `<Trans>has invited you to sign this document</Trans>`). This fragmentation prevents translators from correctly adapting the sentence structure for their language. Many languages do not follow the English Subject-Verb-Object order and may need to place the sender's name at the end of the sentence or use a completely different grammatical structure (e.g., `An invitation to sign was sent by {senderName}`). ### Steps to Reproduce 1. Open the file `DocumentSigningPageViewV1.tsx` 2. Observe messages rendered after line https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L194 and https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L322 ### Expected Behavior The entire sentence should be wrapped in a single `<Trans>` component. Variables should be passed into the component to give translators full context and the flexibility to reorder the sentence elements. Strings to fix: https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L197-L199 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L201 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L206-L208 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L210 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L215-L217 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L219 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L224-L226 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx#L228 ### Current Behavior The sentences are fragmented. ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] Windows 11 ### Browser [e.g., Chrome, Firefox] Chrome ### Version [e.g., 2.0.1] v1.13.1 ### Please check the boxes that apply to this issue report. - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [ ] I have included any relevant screenshots. - [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [x] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:47:47 +03:00

closed this issue
added the
status: triage
label

kerem referenced this issue

2026-02-26 19:31:44 +03:00

[PR #614] [MERGED] docs: re-add launch week 5 blog post #1077

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#614

No description provided.

Rows
Columns