starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[GH-ISSUE #2101] i18n: Missing pluralization for messages with ${maximumEnvelopeItemCount} variable #605

New issue

Closed

opened 2026-02-26 18:47:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:47:45 +03:00

Owner

Originally created by @mKoonrad on GitHub (Oct 24, 2025).
Original GitHub issue: https://github.com/documenso/documenso/issues/2101

Issue Description

In the code, the following string is used 3 times.
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/document/envelope-upload-button.tsx (L167)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx (L239)
github.com/documenso/documenso@9350c53c7d/apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx (L253)

String does not handle pluralization. While English has two forms ("item" and "items"), many other languages (like Polish, Czech, etc.) have more complex plural rules (e.g., forms for 1, 2-4, 5+). The current implementation hardcodes "items", making grammatically correct translations impossible.

Steps to Reproduce

Set the application language to one with complex plural forms (e.g., Polish).
Trigger the error message (e.g., by uploading too many files).
Observe that the translated message for "items" is grammatically incorrect.

Expected Behavior

App should use plural macro for all instances of this message.

Current Behavior

App uses hardcoded string, which prevents correct translations.

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome

Version [e.g., 2.0.1]

v1.13.1

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @mKoonrad on GitHub (Oct 24, 2025). Original GitHub issue: https://github.com/documenso/documenso/issues/2101 ### Issue Description In the code, the following string is used 3 times. https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/document/envelope-upload-button.tsx#L167 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx#L239 https://github.com/documenso/documenso/blob/9350c53c7dc46d05d569ab68241c68ec4a3919d8/apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx#L253 String does not handle pluralization. While English has two forms ("item" and "items"), many other languages (like Polish, Czech, etc.) have more complex plural rules (e.g., forms for 1, 2-4, 5+). The current implementation hardcodes "items", making grammatically correct translations impossible. ### Steps to Reproduce 1. Set the application language to one with complex plural forms (e.g., Polish). 2. Trigger the error message (e.g., by uploading too many files). 3. Observe that the translated message for "items" is grammatically incorrect. ### Expected Behavior App should use plural macro for all instances of this message. ### Current Behavior App uses hardcoded string, which prevents correct translations. ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] Windows 11 ### Browser [e.g., Chrome, Firefox] Chrome ### Version [e.g., 2.0.1] v1.13.1 ### Please check the boxes that apply to this issue report. - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [ ] I have included any relevant screenshots. - [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [ ] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:47:45 +03:00

closed this issue
added the
status: triage
label

kerem referenced this issue

2026-02-26 19:31:43 +03:00

[PR #606] [MERGED] fix: use web app url for share link copying #1073

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#605

No description provided.

Rows
Columns