[GH-ISSUE #22] [DOC-82] Make "Ready to send"-Dialog into component #6

Closed
opened 2026-02-26 18:44:57 +03:00 by kerem · 28 comments
Owner

Originally created by @ElTimuro on GitHub (Mar 21, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/22

From SyncLinear.com | DOC-82

Originally created by @ElTimuro on GitHub (Mar 21, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/22 <sub>From [SyncLinear.com](https://synclinear.com) | [DOC-82](https://linear.app/documenso/issue/DOC-82/make-ready-to-send-dialog-into-component)</sub>
kerem 2026-02-26 18:44:57 +03:00
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

https://cal.video/qJiJwsmeHrL5eAv8WdpX

<!-- gh-comment-id:1477947006 --> @ElTimuro commented on GitHub (Mar 21, 2023): [https://cal.video/qJiJwsmeHrL5eAv8WdpX](https://cal.video/qJiJwsmeHrL5eAv8WdpX) <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Peer just told me how important is that today! Lol I'm still pulling from main… can we call? so you can take a look at it?

<!-- gh-comment-id:1477947028 --> @ElTimuro commented on GitHub (Mar 21, 2023): Peer just told me how important is that today! Lol I'm still pulling from main… can we call? so you can take a look at it? <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

sure

<!-- gh-comment-id:1477947062 --> @ElTimuro commented on GitHub (Mar 21, 2023): sure <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

i switched to another branch now to keep master stable, maybe you did not get the newest version. also be sure to restart the dev server after pull of new db changes

<!-- gh-comment-id:1477947099 --> @ElTimuro commented on GitHub (Mar 21, 2023): i switched to another branch now to keep master stable, maybe you did not get the newest version. also be sure to restart the dev server after pull of new db changes <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Screenshot 2023-03-09 at 13.45.50.png

Sorry, I'm kinda back to unable to signup again… at least now I'm getting the error

<!-- gh-comment-id:1477947130 --> @ElTimuro commented on GitHub (Mar 21, 2023): ![Screenshot 2023-03-09 at 13.45.50.png](https://uploads.linear.app/884f43d5-69da-459d-bc6b-864f16914e0f/78b8a522-8213-45a1-b243-3fffba38bb28/9d0eeeb4-b91c-4d86-babc-90f4d004ae6a) Sorry, I'm kinda back to unable to signup again… at least now I'm getting the error <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

i can take a look live if you want

<!-- gh-comment-id:1477947162 --> @ElTimuro commented on GitHub (Mar 21, 2023): i can take a look live if you want <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

yes

<!-- gh-comment-id:1477947193 --> @ElTimuro commented on GitHub (Mar 21, 2023): yes <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

do you run via npm run dev?

<!-- gh-comment-id:1477947220 --> @ElTimuro commented on GitHub (Mar 21, 2023): do you run via npm run dev? <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

unrelated i just had to reset again, you need to signup again

<!-- gh-comment-id:1477947240 --> @ElTimuro commented on GitHub (Mar 21, 2023): unrelated i just had to reset again, you need to signup again <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

test@example.com -1234567

<!-- gh-comment-id:1477947274 --> @ElTimuro commented on GitHub (Mar 21, 2023): test@example.com -1234567 <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Screenshot 2023-03-09 at 13.29.18.png

I just checked out main and logging in works now, but I get this error now. The .env works but the dashboard is not loading

<!-- gh-comment-id:1477947301 --> @ElTimuro commented on GitHub (Mar 21, 2023): ![Screenshot 2023-03-09 at 13.29.18.png](https://uploads.linear.app/884f43d5-69da-459d-bc6b-864f16914e0f/607e6f6c-672c-4937-90db-c43e56c69eb7/e23adf39-824d-4b02-8398-5f9a76b587cc) I just checked out main and logging in works now, but I get this error now. The .env works but the dashboard is not loading <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

can you send me the user that's supposed to be logged in?

<!-- gh-comment-id:1477947333 --> @ElTimuro commented on GitHub (Mar 21, 2023): can you send me the user that's supposed to be logged in? <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

I pushed the fix to master but it would be good to check this first

<!-- gh-comment-id:1477947348 --> @ElTimuro commented on GitHub (Mar 21, 2023): I pushed the fix to master but it would be good to check this first <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Implementing a fix, that triggers a relogin. Can you check if you still have this and delete and try again if you have?

<!-- gh-comment-id:1477947373 --> @ElTimuro commented on GitHub (Mar 21, 2023): Implementing a fix, that triggers a relogin. Can you check if you still have this and delete and try again if you have? <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Sorry I didn’t reply earlier, I read it then forgot. I deleted the cache and tried but I keep on having the same problem.

<!-- gh-comment-id:1477947396 --> @ElTimuro commented on GitHub (Mar 21, 2023): Sorry I didn’t reply earlier, I read it then forgot. I deleted the cache and tried but I keep on having the same problem. <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

i guess the login auth token has a user encoded that not exists anymore

<!-- gh-comment-id:1477947427 --> @ElTimuro commented on GitHub (Mar 21, 2023): i guess the login auth token has a user encoded that not exists anymore <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

ah could be that i resetted the database by chaning the datamodel. in that case you just have to delete the token you have locally. did you delete the cache?

<!-- gh-comment-id:1477947444 --> @ElTimuro commented on GitHub (Mar 21, 2023): ah could be that i resetted the database by chaning the datamodel. in that case you just have to delete the token you have locally. did you delete the cache? <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Not for me, I kept on trying on incognito and same.

<!-- gh-comment-id:1477947471 --> @ElTimuro commented on GitHub (Mar 21, 2023): Not for me, I kept on trying on incognito and same. <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

delete cache and login login did not resolve for now?

its what i did

<!-- gh-comment-id:1477947510 --> @ElTimuro commented on GitHub (Mar 21, 2023): delete cache and login login did not resolve for now? its what i did <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

I used the "Git pull" command and I'm supposed to be up to date, but unfortunately I’m still having the same issue 🫠

<!-- gh-comment-id:1477947546 --> @ElTimuro commented on GitHub (Mar 21, 2023): I used the "Git pull" command and I'm supposed to be up to date, but unfortunately I’m still having the same issue 🫠 <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

I recently merged my next PR you can try that one, but i encountered that too. seems like a bug. Clear cache and religion should help, I will hunt it down eventually. If you can reproduce, let me know 👌

<!-- gh-comment-id:1477947573 --> @ElTimuro commented on GitHub (Mar 21, 2023): I recently merged my next PR you can try that one, but i encountered that too. seems like a bug. Clear cache and religion should help, I will hunt it down eventually. If you can reproduce, let me know 👌 <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Screenshot 2023-03-03 at 17.15.07.png

Hello! I've been having a problem to run the app locally… It doesn’t even let me create a new user in incognito mode. It happened two days ago after I used the "git pull" command to update. Maybe I changed something without noticing?

<!-- gh-comment-id:1477947598 --> @ElTimuro commented on GitHub (Mar 21, 2023): ![Screenshot 2023-03-03 at 17.15.07.png](https://uploads.linear.app/884f43d5-69da-459d-bc6b-864f16914e0f/b89f90be-aae6-49e5-a22f-1738e0c02c80/0be20960-9a23-4969-a7b1-d54f2908b9e3) Hello! I've been having a problem to run the app locally… It doesn’t even let me create a new user in incognito mode. It happened two days ago after I used the "git pull" command to update. Maybe I changed something without noticing? <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Call on monday?

<!-- gh-comment-id:1477947624 --> @ElTimuro commented on GitHub (Mar 21, 2023): Call on monday? <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Until now I’m trying to kinda replicate it and understand everything that needs to be send in props, also I'm gonna try to keep it in typescript which I haven’t start learning yet but I’m reading about how the props in typescript work. I would appreciate the architecture details

<!-- gh-comment-id:1477947646 --> @ElTimuro commented on GitHub (Mar 21, 2023): Until now I’m trying to kinda replicate it and understand everything that needs to be send in props, also I'm gonna try to keep it in typescript which I haven’t start learning yet but I’m reading about how the props in typescript work. I would appreciate the architecture details <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Since this is next: You can see a working dialog here: The architecture is based on a DialogResult which the dialog component dispatches and an event on close. Let me know If you need input for the architecture if you are new to events and handlers

<!-- gh-comment-id:1477947671 --> @ElTimuro commented on GitHub (Mar 21, 2023): Since this is next: You can see a working dialog here: The architecture is based on a DialogResult which the dialog component dispatches and an event on close. Let me know If you need input for the architecture if you are new to events and handlers <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

Yes. I'll always let you know, if tasks we discussed should not be done anymore

<!-- gh-comment-id:1477947711 --> @ElTimuro commented on GitHub (Mar 21, 2023): Yes. I'll always let you know, if tasks we discussed should not be done anymore <!-- From timur.ercan31 on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 21, 2023):

I am currently working on this issue. Do you still want me to move forward and make it a component ?

<!-- gh-comment-id:1477947736 --> @ElTimuro commented on GitHub (Mar 21, 2023): I am currently working on this issue. Do you still want me to move forward and make it a component ? <!-- From estherlitalg on Linear -->
Author
Owner

@ElTimuro commented on GitHub (Mar 27, 2023):

Assigned to Ephraim

<!-- gh-comment-id:1484925086 --> @ElTimuro commented on GitHub (Mar 27, 2023): Assigned to Ephraim <!-- From Timur Ercan on Linear -->
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#6
No description provided.