starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[GH-ISSUE #2052] Translations broken in 1.12.7 #588

New issue

Open

opened 2026-02-26 18:47:41 +03:00 by kerem · 8 comments

kerem commented

2026-02-26 18:47:41 +03:00

Owner

Originally created by @samuel-cglg on GitHub (Sep 26, 2025).
Original GitHub issue: https://github.com/documenso/documenso/issues/2052

Issue Description

After updating to 1.12.7, I can see some translations broken in the signing invite email.
For example, this is the email the signer user receives after the requester created a signature request (in French):

In the email, the word "sign" should have been translated into "signer" (French).

I guess this was introduced in e547b0b410 and I am afraid it also impacts other places.

Steps to Reproduce

Create and send a signing request in a language other than English.

Expected Behavior

The signing request email content is translated.

Current Behavior

The signing request email has some words not translated.

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

No response

Browser [e.g., Chrome, Firefox]

No response

Version [e.g., 2.0.1]

No response

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @samuel-cglg on GitHub (Sep 26, 2025). Original GitHub issue: https://github.com/documenso/documenso/issues/2052 ### Issue Description After updating to 1.12.7, I can see some translations broken in the signing invite email. For example, this is the email the signer user receives after the requester created a signature request (in French): <img width="521" height="624" alt="Image" src="https://github.com/user-attachments/assets/aed6aa93-3897-4051-b275-b90950711b7d" /> In the email, the word "sign" should have been translated into "signer" (French). I guess this was introduced in e547b0b410224696b5cf2a8a5eccff6dde8f89fb and I am afraid it also impacts other places. ### Steps to Reproduce Create and send a signing request in a language other than English. ### Expected Behavior The signing request email content is translated. ### Current Behavior The signing request email has some words not translated. ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] _No response_ ### Browser [e.g., Chrome, Firefox] _No response_ ### Version [e.g., 2.0.1] _No response_ ### Please check the boxes that apply to this issue report. - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [x] I have included any relevant screenshots. - [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [x] I want to work on creating a PR for this issue if approved

kerem added the

status: triage

label

2026-02-26 18:47:41 +03:00

kerem commented

2026-02-26 18:47:42 +03:00

Author

Owner

@mKoonrad commented on GitHub (Oct 3, 2025):

I guess this was introduced in e547b0b and I am afraid it also impacts other places.

All new or changed translations are unavailable until translation extraction process is run.

Two days ago, @Mythie manually extracted translations. Previous update of .po file was in August.

Similar problems will continue to occur until the extraction process is automated. This file must be generated every new commit. I hope this process can be improved soon.

@mKoonrad commented on GitHub (Oct 3, 2025): > I guess this was introduced in [e547b0b](https://github.com/documenso/documenso/commit/e547b0b410224696b5cf2a8a5eccff6dde8f89fb) and I am afraid it also impacts other places. All new or changed translations are unavailable until translation extraction process is run. Two days ago, @Mythie manually extracted translations. Previous update of .po file was in August. Similar problems will continue to occur until the extraction process is automated. This file must be generated every new commit. I hope this process can be improved soon.

kerem commented

2026-02-26 18:47:42 +03:00

Author

Owner

@samuel-cglg commented on GitHub (Oct 6, 2025):

Thanks for the info, I thought there was some automatic process to generate .po files from Crowdin.

I agree that this part should be improved. If not automatic, at least one extraction before releasing a new version would be a good start.

@samuel-cglg commented on GitHub (Oct 6, 2025): Thanks for the info, I thought there was some automatic process to generate .po files from Crowdin. I agree that this part should be improved. If not automatic, at least one extraction before releasing a new version would be a good start.

kerem commented

2026-02-26 18:47:42 +03:00

Author

Owner

@lucien-klarc commented on GitHub (Jan 5, 2026):

Hi,

Could you please explain in plain english if there is anything i can do to fix this issue?

Thank you very much.
Lucien

@lucien-klarc commented on GitHub (Jan 5, 2026): Hi, Could you please explain in plain english if there is anything i can do to fix this issue? Thank you very much. Lucien

kerem commented

2026-02-26 18:47:42 +03:00

Author

Owner

@mKoonrad commented on GitHub (Jan 5, 2026):

@lucien-klarc It's solved now.

@mKoonrad commented on GitHub (Jan 5, 2026): @lucien-klarc It's solved now.

kerem commented

2026-02-26 18:47:42 +03:00

Author

Owner

@lucien-klarc commented on GitHub (Jan 6, 2026):

Thank you @mKoonrad !

@lucien-klarc commented on GitHub (Jan 6, 2026): Thank you @mKoonrad !

kerem commented

2026-02-26 18:47:42 +03:00

Author

Owner

@lucien-klarc commented on GitHub (Jan 6, 2026):

Thank you again, I can see the pull request however, I am not skilled enough to understand how to have this implemented in my deployment. I am currently using a docker compose with “latest” tag. But as far as I understand, the latest version does not seem to have the fix. How does it work in this event? I apologize for the candid question and thank you for your time!

@lucien-klarc commented on GitHub (Jan 6, 2026): Thank you again, I can see the pull request however, I am not skilled enough to understand how to have this implemented in my deployment. I am currently using a docker compose with “latest” tag. But as far as I understand, the latest version does not seem to have the fix. How does it work in this event? I apologize for the candid question and thank you for your time!

kerem commented

2026-02-26 18:47:42 +03:00

Author

Owner

@mKoonrad commented on GitHub (Jan 6, 2026):

@lucien-klarc Please check in French web.po file translations for packages/lib/constants/recipient-roles.ts

github.com/documenso/documenso@f6d81b22bd/packages/lib/translations/fr/web.po (L7910-L7913)

It should be "signer" (with a lowercase letter)?

@mKoonrad commented on GitHub (Jan 6, 2026): @lucien-klarc Please check in French web.po file translations for [packages/lib/constants/recipient-roles.ts ](https://github.com/documenso/documenso/blob/f6d81b22bd3b09c531bada1e647fd525de3bc55b/packages/lib/constants/recipient-roles.ts) https://github.com/documenso/documenso/blob/f6d81b22bd3b09c531bada1e647fd525de3bc55b/packages/lib/translations/fr/web.po#L7910-L7913 It should be "signer" (with a lowercase letter)?

kerem commented

2026-02-26 18:47:42 +03:00

Author

Owner

@lucien-klarc commented on GitHub (Jan 8, 2026):

Hi @mKoonrad,
Thank you my issue is solved !

@lucien-klarc commented on GitHub (Jan 8, 2026): Hi @mKoonrad, Thank you my issue is solved !

kerem referenced this issue

2026-02-26 19:31:40 +03:00

[PR #588] [MERGED] chore: use minio as s3 storage for document during development #1063

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#588

No description provided.

Rows
Columns