[GH-ISSUE #1465] Localization issue in country with gender-specific nouns and verbs #417

Open
opened 2026-02-26 18:46:58 +03:00 by kerem · 0 comments
Owner

Originally created by @mKoonrad on GitHub (Nov 12, 2024).
Original GitHub issue: https://github.com/documenso/documenso/issues/1465

Issue Description

Please stop using code to create full sentence from parts
packages/lib/constants/recipient-roles.ts
packages/lib/jobs/definitions/emails/send-signing-email.ts
packages/lib/server-only/document/resend-document.tsx
packages/email/templates/document-invite.tsx
packages/email/templates/document-created-from-direct-template.tsx
packages/email/templates/document-invite.tsx

In some language (like Polish) we have something like Polish cases. Or we need to adjust noun or verb to specific form related to whole sentence. We can't create correct translation like in English.

For example:
sign (noun) -> podpis
Please sign -> Podpisz (starting sentence from Please is obsolete)
I signed -> Ja podpisałem
1 user signed -> 1 użytkownik podpisał
2 user signed -> 2 użytkowników podpisało

Steps to Reproduce

I tried to prepare correct translations

Expected Behavior

Full strings using variable only with document name etc.

Current Behavior

Incorrect translations

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

No response

Browser [e.g., Chrome, Firefox]

No response

Version [e.g., 2.0.1]

No response

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
Originally created by @mKoonrad on GitHub (Nov 12, 2024). Original GitHub issue: https://github.com/documenso/documenso/issues/1465 ### Issue Description Please stop using code to create full sentence from parts [packages/lib/constants/recipient-roles.ts](https://github.com/documenso/documenso/blob/f2439abbc9e3215c202b646cc16f503d80ec91a2/packages/lib/constants/recipient-roles.ts#L4) [packages/lib/jobs/definitions/emails/send-signing-email.ts](https://github.com/documenso/documenso/blob/f2439abbc9e3215c202b646cc16f503d80ec91a2/packages/lib/jobs/definitions/emails/send-signing-email.ts#L4) [packages/lib/server-only/document/resend-document.tsx](https://github.com/documenso/documenso/blob/f2439abbc9e3215c202b646cc16f503d80ec91a2/packages/lib/server-only/document/resend-document.tsx#L4) [packages/email/templates/document-invite.tsx](https://github.com/documenso/documenso/blob/f2439abbc9e3215c202b646cc16f503d80ec91a2/packages/email/templates/document-invite.tsx#L4) [packages/email/templates/document-created-from-direct-template.tsx](https://github.com/documenso/documenso/blob/f2439abbc9e3215c202b646cc16f503d80ec91a2/packages/email/templates/document-created-from-direct-template.tsx#L4) [packages/email/templates/document-invite.tsx](https://github.com/documenso/documenso/blob/f2439abbc9e3215c202b646cc16f503d80ec91a2/packages/email/templates/document-invite.tsx#L4) In some language (like Polish) we have something like Polish cases. Or we need to adjust noun or verb to specific form related to whole sentence. We can't create correct translation like in English. For example: sign (noun) -> podpis Please sign -> Podpisz (starting sentence from Please is obsolete) I signed -> Ja podpisałem 1 user signed -> 1 użytkownik podpisał 2 user signed -> 2 użytkowników podpisało ### Steps to Reproduce I tried to prepare correct translations ### Expected Behavior Full strings using variable only with document name etc. ### Current Behavior Incorrect translations ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] _No response_ ### Browser [e.g., Chrome, Firefox] _No response_ ### Version [e.g., 2.0.1] _No response_ ### Please check the boxes that apply to this issue report. - [X] I have searched the existing issues to make sure this is not a duplicate. - [X] I have provided steps to reproduce the issue. - [ ] I have included relevant environment information. - [ ] I have included any relevant screenshots. - [X] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [X] I want to work on creating a PR for this issue if approved
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#417
No description provided.