[GH-ISSUE #1032] Command Menu Fails to Close on First 'Escape' Click; Requires Second Click for Closure #318

Closed
opened 2026-02-26 18:46:28 +03:00 by kerem · 3 comments
Owner

Originally created by @deepgolani4 on GitHub (Mar 17, 2024).
Original GitHub issue: https://github.com/documenso/documenso/issues/1032

Originally assigned to: @deepgolani4 on GitHub.

Issue Description And Repro steps

Open the Command menu with ⌘+K.

When clicking "Escape" for the first time.
Screenshot 2024-03-17 at 8 04 18 PM

Clicking "Escape" a second time closes the command menu.

Expected Behavior

The command menu should close upon the first press of the "Escape" key.

Operating System [e.g., Windows 10]

MAC OS 17.1

Browser [e.g., Chrome, Firefox]

Arc (Chromium based browser)

Version [e.g., 2.0.1]

1.33.0

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
Originally created by @deepgolani4 on GitHub (Mar 17, 2024). Original GitHub issue: https://github.com/documenso/documenso/issues/1032 Originally assigned to: @deepgolani4 on GitHub. ### Issue Description And Repro steps Open the Command menu with ⌘+K. When clicking "Escape" for the first time. <img width="1237" alt="Screenshot 2024-03-17 at 8 04 18 PM" src="https://github.com/documenso/documenso/assets/54791570/69805381-d750-4183-b9b4-7eb08b95e005"> Clicking "Escape" a second time closes the command menu. ### Expected Behavior The command menu should close upon the first press of the "Escape" key. ### Operating System [e.g., Windows 10] MAC OS 17.1 ### Browser [e.g., Chrome, Firefox] Arc (Chromium based browser) ### Version [e.g., 2.0.1] 1.33.0 ### Please check the boxes that apply to this issue report. - [ ] I have searched the existing issues to make sure this is not a duplicate. - [X] I have provided steps to reproduce the issue. - [X] I have included relevant environment information. - [X] I have included any relevant screenshots. - [ ] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [X] I want to work on creating a PR for this issue if approved
Author
Owner

@github-actions[bot] commented on GitHub (Mar 17, 2024):

Thank you for opening your first issue and for being a part of the open signing revolution!

One of our team members will review it and get back to you as soon as it possible 💚

Meanwhile, please feel free to hop into our community in Discord

<!-- gh-comment-id:2002496168 --> @github-actions[bot] commented on GitHub (Mar 17, 2024): Thank you for opening your first issue and for being a part of the open signing revolution! <br /> One of our team members will review it and get back to you as soon as it possible 💚 <br /> Meanwhile, please feel free to hop into our community in [Discord](https://documen.so/discord)
Author
Owner

@Mythie commented on GitHub (Mar 18, 2024):

Looks like this is due to two command windows opening instead of the one which is weird. Happy to have you work on it!

<!-- gh-comment-id:2002700601 --> @Mythie commented on GitHub (Mar 18, 2024): Looks like this is due to two command windows opening instead of the one which is weird. Happy to have you work on it!
Author
Owner

@deepgolani4 commented on GitHub (Mar 18, 2024):

@Mythie, I accidentally unassigned this task from myself.
Could you please assign it back to me?
Thank you

<!-- gh-comment-id:2003249021 --> @deepgolani4 commented on GitHub (Mar 18, 2024): @Mythie, I accidentally unassigned this task from myself. Could you please assign it back to me? Thank you
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#318
No description provided.