starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[GH-ISSUE #1021] Empty team state required #314

New issue

Closed

opened 2026-02-26 18:46:27 +03:00 by kerem · 5 comments

kerem commented

2026-02-26 18:46:27 +03:00

Owner

Originally created by @Gautam-Hegde on GitHub (Mar 12, 2024).
Original GitHub issue: https://github.com/documenso/documenso/issues/1021

Originally assigned to: @Gautam-Hegde on GitHub.

Feature Description

Instead of displaying UserSettingsTeamsPageDataTable when no teams have been created, which leads to a bug in DataTablePagination, we can have a new EmptyTeamState

https://www.loom.com/share/484e0d5250e04b27a2c2eef116d62a62?sid=931abc1c-c6d5-4d97-a853-62fefaa8b432

Use Case

No response

Proposed Solution

Alternatives (optional)

No response

Additional Context

No response

Please check the boxes that apply to this feature request.

I have searched the existing feature requests to make sure this is not a duplicate.
I have provided a detailed description of the requested feature.
I have explained the use case or scenario for this feature.
I have included any relevant technical details or design suggestions.
I understand that this is a suggestion and that there is no guarantee of implementation.
I want to work on creating a PR for this issue if approved

Originally created by @Gautam-Hegde on GitHub (Mar 12, 2024). Original GitHub issue: https://github.com/documenso/documenso/issues/1021 Originally assigned to: @Gautam-Hegde on GitHub. ### Feature Description - Instead of displaying `UserSettingsTeamsPageDataTable` when no teams have been created, which leads to a bug in `DataTablePagination`, we can have a new `EmptyTeamState` https://www.loom.com/share/484e0d5250e04b27a2c2eef116d62a62?sid=931abc1c-c6d5-4d97-a853-62fefaa8b432 ### Use Case _No response_ ### Proposed Solution ![chore ets](https://github.com/documenso/documenso/assets/85569489/3c92ca05-025c-49c6-8fc8-c45cf0a4e3ac) ### Alternatives (optional) _No response_ ### Additional Context _No response_ ### Please check the boxes that apply to this feature request. - [X] I have searched the existing feature requests to make sure this is not a duplicate. - [X] I have provided a detailed description of the requested feature. - [X] I have explained the use case or scenario for this feature. - [x] I have included any relevant technical details or design suggestions. - [X] I understand that this is a suggestion and that there is no guarantee of implementation. - [X] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:46:27 +03:00

closed this issue
added the
type: bug

status: assigned

apps: web

component: ui
labels

kerem commented

2026-02-26 18:46:28 +03:00

Author

Owner

@dguyen commented on GitHub (Mar 13, 2024):

Hi!

What's this pagination bug you're referring to?

@dguyen commented on GitHub (Mar 13, 2024): Hi! What's this pagination bug you're referring to?

kerem commented

2026-02-26 18:46:28 +03:00

Author

Owner

@Gautam-Hegde commented on GitHub (Mar 13, 2024):

It shows page 1 of 0 without any teams

@Gautam-Hegde commented on GitHub (Mar 13, 2024): It shows **page 1 of 0** without any teams

kerem commented

2026-02-26 18:46:28 +03:00

Author

Owner

@dguyen commented on GitHub (Mar 13, 2024):

I think it's better to fix that instead, since the table is searchable and we have skeletons

@dguyen commented on GitHub (Mar 13, 2024): I think it's better to fix that instead, since the table is searchable and we have skeletons

kerem commented

2026-02-26 18:46:28 +03:00

Author

Owner

@Gautam-Hegde commented on GitHub (Mar 13, 2024):

I was considering this because it would maintain consistency, as documents and templates also utilize that empty state component.

@Gautam-Hegde commented on GitHub (Mar 13, 2024): I was considering this because it would maintain consistency, as documents and templates also utilize that empty state component.

kerem commented

2026-02-26 18:46:28 +03:00

Author

Owner

@dguyen commented on GitHub (Mar 13, 2024):

Yeah those are rendered on the server so there's no loading UI associated with them.

Whereas the data for this component is being loaded on the client side, so we currently prefer to not have any empty state like that.

@dguyen commented on GitHub (Mar 13, 2024): Yeah those are rendered on the server so there's no loading UI associated with them. Whereas the data for this component is being loaded on the client side, so we _currently_ prefer to not have any empty state like that.

kerem referenced this issue

2026-02-26 19:30:49 +03:00

[PR #314] [MERGED] fix: removed unnecessary whitespace before className #869

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#314

No description provided.

Rows
Columns