starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-26 06:15:58 +03:00

[GH-ISSUE #965] Show close icon on notification in mobile #295

New issue

Closed

opened 2026-02-26 18:46:22 +03:00 by kerem · 10 comments

kerem commented

2026-02-26 18:46:22 +03:00

Owner

Originally created by @plxity on GitHub (Feb 27, 2024).
Original GitHub issue: https://github.com/documenso/documenso/issues/965

Originally assigned to: @plxity on GitHub.

Issue Description

We display a close icon on notifications on hover, but for mobile and tablet category devices, there is no hover state. In such cases, we should show the close icon by default.

Steps to Reproduce

Perform any action that displays notifications and view it on mobile. Please check the video I've uploaded for reference as well.

Expected Behavior

The close icon should be displayed always on mobile devices.

Current Behavior

Only on focus it is getting displayed.

Screenshots (optional)

https://github.com/documenso/documenso/assets/28510494/580fd9a0-b73a-485d-a087-85a26d479295

Operating System [e.g., Windows 10]

No response

Browser [e.g., Chrome, Firefox]

No response

Version [e.g., 2.0.1]

No response

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @plxity on GitHub (Feb 27, 2024). Original GitHub issue: https://github.com/documenso/documenso/issues/965 Originally assigned to: @plxity on GitHub. ### Issue Description We display a close icon on notifications on hover, but for mobile and tablet category devices, there is no hover state. In such cases, we should show the close icon by default. ### Steps to Reproduce Perform any action that displays notifications and view it on mobile. Please check the video I've uploaded for reference as well. ### Expected Behavior The close icon should be displayed always on mobile devices. ### Current Behavior Only on focus it is getting displayed. ### Screenshots (optional) https://github.com/documenso/documenso/assets/28510494/580fd9a0-b73a-485d-a087-85a26d479295 ### Operating System [e.g., Windows 10] _No response_ ### Browser [e.g., Chrome, Firefox] _No response_ ### Version [e.g., 2.0.1] _No response_ ### Please check the boxes that apply to this issue report. - [X] I have searched the existing issues to make sure this is not a duplicate. - [X] I have provided steps to reproduce the issue. - [X] I have included relevant environment information. - [X] I have included any relevant screenshots. - [X] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [X] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:46:22 +03:00

closed this issue
added the
type: bug

status: assigned

component: ui
labels

kerem commented

2026-02-26 18:46:22 +03:00

Author

Owner

@Mythie commented on GitHub (Feb 27, 2024):

On mobile they're swipe to dismiss instead afaik 😄

Adding a close icon would likely not net a good result either since the touch target would be so small it would be easy to miss and/or accidentally dismiss something you were reading.

@Mythie commented on GitHub (Feb 27, 2024): On mobile they're swipe to dismiss instead afaik 😄 Adding a close icon would likely not net a good result either since the touch target would be so small it would be easy to miss and/or accidentally dismiss something you were reading.

kerem commented

2026-02-26 18:46:22 +03:00

Author

Owner

@plxity commented on GitHub (Feb 27, 2024):

Alright, then maybe we should not show the close icon on the focus state in mobile, we can do display: none if it's mobile, just a thought. What do you think?

@plxity commented on GitHub (Feb 27, 2024): Alright, then maybe we should not show the close icon on the focus state in mobile, we can do display: none if it's mobile, just a thought. What do you think?

kerem commented

2026-02-26 18:46:22 +03:00

Author

Owner

@dguyen commented on GitHub (Feb 29, 2024):

Swipe up to dismiss doesn't work for me on iOS mobile

In such cases, we should show the close icon by default.

Lets make it always show on mobile only for now

@dguyen commented on GitHub (Feb 29, 2024): Swipe up to dismiss doesn't work for me on iOS mobile > In such cases, we should show the close icon by default. Lets make it always show on mobile only for now

kerem commented

2026-02-26 18:46:22 +03:00

Author

Owner

@ameeetgaikwad commented on GitHub (Mar 4, 2024):

@plxity if you are not working on this, would like to take this one!

@ameeetgaikwad commented on GitHub (Mar 4, 2024): @plxity if you are not working on this, would like to take this one!

kerem commented

2026-02-26 18:46:22 +03:00

Author

Owner

@plxity commented on GitHub (Mar 5, 2024):

@ameeetgaikwad I'm working on it

@plxity commented on GitHub (Mar 5, 2024): @ameeetgaikwad I'm working on it

kerem commented

2026-02-26 18:46:23 +03:00

Author

Owner

@rohit-saluja commented on GitHub (Mar 7, 2024):

I created a pull request for this

@rohit-saluja commented on GitHub (Mar 7, 2024): I created a [pull request](https://github.com/documenso/documenso/pull/996) for this

kerem commented

2026-02-26 18:46:23 +03:00

Author

Owner

@plxity commented on GitHub (Mar 7, 2024):

@rohit-saluja that's good. but you should've not done it. I already said i'm working on it in background. Please take care of it next time.

@plxity commented on GitHub (Mar 7, 2024): @rohit-saluja that's good. but you should've not done it. I already said i'm working on it in background. Please take care of it next time.

kerem commented

2026-02-26 18:46:23 +03:00

Author

Owner

@Mythie commented on GitHub (Mar 8, 2024):

So to confirm, @plxity do you wish to continue on this PR? Rohit's solution is correct but since it was assigned to you we're happy to close it off and let you raise yours instead 😄

Apologies for the confusion @rohit-saluja issues raised here get assigned to avoid any double work and hurt feelings 😸

@Mythie commented on GitHub (Mar 8, 2024): So to confirm, @plxity do you wish to continue on this PR? Rohit's solution is correct but since it was assigned to you we're happy to close it off and let you raise yours instead 😄 Apologies for the confusion @rohit-saluja issues raised here get assigned to avoid any double work and hurt feelings 😸

kerem commented

2026-02-26 18:46:23 +03:00

Author

Owner

@plxity commented on GitHub (Mar 10, 2024):

@Mythie We can go ahead with the PR, no worries :)

@plxity commented on GitHub (Mar 10, 2024): @Mythie We can go ahead with the PR, no worries :)

kerem commented

2026-02-26 18:46:23 +03:00

Author

Owner

@Mythie commented on GitHub (Mar 10, 2024):

Cheers Apoorv!

@Mythie commented on GitHub (Mar 10, 2024): Cheers Apoorv! ![thank-you-stronk](https://github.com/documenso/documenso/assets/13398220/7fa9ca0e-b899-4b0c-9d16-632493490355)

kerem referenced this issue

2026-02-26 19:30:46 +03:00

[PR #295] [MERGED] fix: use -p cli option for next dev #855

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#295

No description provided.

Rows
Columns