[GH-ISSUE #908] [Bug] Documents can be sent with no fields at all to sign #280

Closed
opened 2026-02-26 18:46:17 +03:00 by kerem · 4 comments
Owner

Originally created by @sumitbishti on GitHub (Feb 5, 2024).
Original GitHub issue: https://github.com/documenso/documenso/issues/908

Issue Description

Currently we can send documents having no fields (date, name, signature, email) to get signed.

Steps to Reproduce

Upload a doc
enter title and email
do not select any fields, hit continue
it will be sent to the recipient with no fields

Expected Behavior

the doc to be sent should have at least one field(signature)

Current Behavior

No response

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

No response

Browser [e.g., Chrome, Firefox]

No response

Version [e.g., 2.0.1]

No response

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
Originally created by @sumitbishti on GitHub (Feb 5, 2024). Original GitHub issue: https://github.com/documenso/documenso/issues/908 ### Issue Description Currently we can send documents having no fields (date, name, signature, email) to get signed. ### Steps to Reproduce Upload a doc enter title and email do not select any fields, hit continue it will be sent to the recipient with no fields ### Expected Behavior the doc to be sent should have at least one field(signature) ### Current Behavior _No response_ ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] _No response_ ### Browser [e.g., Chrome, Firefox] _No response_ ### Version [e.g., 2.0.1] _No response_ ### Please check the boxes that apply to this issue report. - [X] I have searched the existing issues to make sure this is not a duplicate. - [X] I have provided steps to reproduce the issue. - [X] I have included relevant environment information. - [X] I have included any relevant screenshots. - [X] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [X] I want to work on creating a PR for this issue if approved
Author
Owner

@ElTimuro commented on GitHub (Feb 5, 2024):

Yes, this behavior is not correct/ wanted. A solution we already discussed internally:
Allowing documents with no fields, but forcing the user to place one during signing (with optional fields like date, etc.)

@Mythie let me know if we should do this ourselves our accept contributions
@sumitbishti would you be interested in working on this if we accept contributions on this? Thanks for reporting this so far :)

<!-- gh-comment-id:1927851404 --> @ElTimuro commented on GitHub (Feb 5, 2024): Yes, this behavior is not correct/ wanted. A solution we already discussed internally: Allowing documents with no fields, but forcing the user to place one during signing (with optional fields like date, etc.) @Mythie let me know if we should do this ourselves our accept contributions @sumitbishti would you be interested in working on this if we accept contributions on this? Thanks for reporting this so far :)
Author
Owner

@sumitbishti commented on GitHub (Feb 6, 2024):

Yes, I would be interested in working on this for sure.

<!-- gh-comment-id:1928720793 --> @sumitbishti commented on GitHub (Feb 6, 2024): Yes, I would be interested in working on this for sure.
Author
Owner

@hiteshwadhwani commented on GitHub (Feb 8, 2024):

If this issue is not fixed yet I would like to work on this

<!-- gh-comment-id:1934688298 --> @hiteshwadhwani commented on GitHub (Feb 8, 2024): If this issue is not fixed yet I would like to work on this
Author
Owner

@ElTimuro commented on GitHub (Feb 13, 2024):

@Mythie afaik we are not internally working on this, right? Should have take submissions for this?

My suggested solution:

  • Sending without any field is still possible
  • The recipient can place signatures and other fields freely as they choose
  • Freely adding fields as the signer should also be possible for documents with fields. If this is possible should be configurable under "Avanced" before Document sending
<!-- gh-comment-id:1941829775 --> @ElTimuro commented on GitHub (Feb 13, 2024): @Mythie afaik we are not internally working on this, right? Should have take submissions for this? My suggested solution: - Sending without any field is still possible - The recipient can place signatures and other fields freely as they choose - Freely adding fields as the signer should also be possible for documents with fields. If this is possible should be configurable under "Avanced" before Document sending
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#280
No description provided.