starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[GH-ISSUE #67] [DOC-224] Bad Gateway Page and just a tiny quick error message (when sending to two recipients isnt possible) → not possibe to get back to the account via back button automatically, you need to use the back button and refresh the page #27

New issue

Closed

opened 2026-02-26 18:45:01 +03:00 by kerem · 5 comments

kerem commented

2026-02-26 18:45:01 +03:00

Owner

Originally created by @ElTimuro on GitHub (Apr 11, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/67

_{From SyncLinear.com | DOC-224}

Originally created by @ElTimuro on GitHub (Apr 11, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/67 <sub>From [SyncLinear.com](https://synclinear.com) | [DOC-224](https://linear.app/documenso/issue/DOC-224/bad-gateway-page-and-just-a-tiny-quick-error-message-when-sending-to)</sub>

kerem

2026-02-26 18:45:01 +03:00

closed this issue
added the
type: bug
label

kerem commented

2026-02-26 18:45:02 +03:00

Author

Owner

@ElTimuro commented on GitHub (Apr 21, 2023):

-Here is a loom of the error: https://www.loom.com/share/b66ffe679916408e87e27b27a620bd9a

The invalid recipients should be ignored in backend
Exceptions need to be caught at sending level and endpoint level, no endpoint should escalate to complete 502
This escalates to the top level and is only healed by render restarting automatically
This works suprisignly well, but is not sound

@Mythie

@ElTimuro commented on GitHub (Apr 21, 2023): -Here is a loom of the error: https://www.loom.com/share/b66ffe679916408e87e27b27a620bd9a - The invalid recipients should be ignored in backend - Exceptions need to be caught at sending level and endpoint level, no endpoint should escalate to complete 502 - This escalates to the top level and is only healed by render restarting automatically - This works suprisignly well, but is not sound ![image](https://user-images.githubusercontent.com/1309312/233611374-780601bd-c4ba-42b6-8965-ea422e4510ab.png) ![image](https://user-images.githubusercontent.com/1309312/233611525-ea2fc44e-ab1f-47b4-883e-b47055a0e186.png) ![image](https://user-images.githubusercontent.com/1309312/233611637-a7a5e73a-5d53-4129-b1fa-50803a60b78a.png) @Mythie

kerem commented

2026-02-26 18:45:02 +03:00

Author

Owner

@ephraimduncan commented on GitHub (Apr 21, 2023):

Exceptions need to be caught at sending level and endpoint level

This PR by @SauravL3010 (https://github.com/documenso/documenso/pull/70) removes the empty fields on the frontend end before sending them which I think it is a first step in solving this issue

@Mythie, I would like to take this if you're not working on it.

cc: @ElTimuro

@ephraimduncan commented on GitHub (Apr 21, 2023): > Exceptions need to be caught at sending level and endpoint level This PR by @SauravL3010 (https://github.com/documenso/documenso/pull/70) removes the empty fields on the frontend end before sending them which I think it is a first step in solving this issue @Mythie, I would like to take this if you're not working on it. cc: @ElTimuro

kerem commented

2026-02-26 18:45:02 +03:00

Author

Owner

@ElTimuro commented on GitHub (Apr 21, 2023):

@dephraiim True for the concrete error, but such an error maybe never bubble this high
There is some architecture level Error Handling missing here

@ElTimuro commented on GitHub (Apr 21, 2023): - @dephraiim True for the concrete error, but such an error maybe never bubble this high - There is some architecture level Error Handling missing here

kerem commented

2026-02-26 18:45:02 +03:00

Author

Owner

@Mythie commented on GitHub (Apr 21, 2023):

Sounds great, first thing to do is handle exceptions in the method that sends the signing request to all members. Try to handle empty values or non email-like values gracefully by skipping them.

Use a simple regex like .+@.+ for checking email validity since the standard for emails is quite funky.

If we encounter an error with sending it'd be nice to get either a 400 or 500 response with details that could be displayed within the toast so the user can action it.

e.g.

"We were unable to send the signing request to , please ensure their email is correct and try again"

@Mythie commented on GitHub (Apr 21, 2023): Sounds great, first thing to do is handle exceptions in the method that sends the signing request to all members. Try to handle empty values or non email-like values gracefully by skipping them. Use a simple regex like `.+@.+` for checking email validity since the standard for emails is quite funky. If we encounter an error with sending it'd be nice to get either a 400 or 500 response with details that could be displayed within the toast so the user can action it. e.g. "We were unable to send the signing request to <email>, please ensure their email is correct and try again"

kerem commented

2026-02-26 18:45:02 +03:00

Author

Owner

@Musacoli commented on GitHub (May 29, 2023):

Hi @Mythie and @dephraiim ,
Is any one of you actively working on this? If not I'd like to take it up as my first issue.

@Musacoli commented on GitHub (May 29, 2023): Hi @Mythie and @dephraiim , Is any one of you actively working on this? If not I'd like to take it up as my first issue.

kerem referenced this issue

2026-02-26 18:48:36 +03:00

[PR #27] [MERGED] Close panel on when user clicks on a nav link #715

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#27

No description provided.

Rows
Columns