[GH-ISSUE #886] Field Sizing #268

Open
opened 2026-02-26 18:46:13 +03:00 by kerem · 14 comments
Owner

Originally created by @ElTimuro on GitHub (Jan 30, 2024).
Original GitHub issue: https://github.com/documenso/documenso/issues/886

Originally assigned to: @hkrhemendra on GitHub.

Describe the improvement you are suggesting in detail

  • Signature and other fields below a certain size don't make sense
  • The value placeholder should be respected by the minimum size
  • An absolute minimum size needs to be defined
  • They may be even bad pattern because hard to see

Additional Information & Alternatives (optional)

  • No real alternative, just letting the size adjustable completely free can lead to some not so nice/ hard to hit fields

Do you want to work on this improvement?

No

Please check the boxes that apply to this improvement suggestion.

  • I have searched the existing issues and improvement suggestions to avoid duplication.
  • I have provided a clear description of the improvement being suggested.
  • I have explained the rationale behind this improvement.
  • I have included any relevant technical details or design suggestions.
  • I understand that this is a suggestion and that there is no guarantee of implementation.
Originally created by @ElTimuro on GitHub (Jan 30, 2024). Original GitHub issue: https://github.com/documenso/documenso/issues/886 Originally assigned to: @hkrhemendra on GitHub. ### Describe the improvement you are suggesting in detail - Signature and other fields below a certain size don't make sense - The value placeholder should be respected by the minimum size - An absolute minimum size needs to be defined - They may be even bad pattern because hard to see ### Additional Information & Alternatives (optional) - No real alternative, just letting the size adjustable completely free can lead to some not so nice/ hard to hit fields ### Do you want to work on this improvement? No ### Please check the boxes that apply to this improvement suggestion. - [X] I have searched the existing issues and improvement suggestions to avoid duplication. - [X] I have provided a clear description of the improvement being suggested. - [X] I have explained the rationale behind this improvement. - [X] I have included any relevant technical details or design suggestions. - [X] I understand that this is a suggestion and that there is no guarantee of implementation.
Author
Owner

@FatumaA commented on GitHub (Jan 30, 2024):

I'd like to pick this up

<!-- gh-comment-id:1917677019 --> @FatumaA commented on GitHub (Jan 30, 2024): I'd like to pick this up
Author
Owner

@newtronahmed commented on GitHub (Jan 30, 2024):

Am interested in taking this on

<!-- gh-comment-id:1917705601 --> @newtronahmed commented on GitHub (Jan 30, 2024): Am interested in taking this on
Author
Owner

@ephraimduncan commented on GitHub (Jan 30, 2024):

@FatumaA I'll be assigning this to you since you were the first

<!-- gh-comment-id:1918037754 --> @ephraimduncan commented on GitHub (Jan 30, 2024): @FatumaA I'll be assigning this to you since you were the first
Author
Owner

@FatumaA commented on GitHub (Feb 6, 2024):

Hi @dephraiim,
I took a look here and I'm stuck on actually finding the right part of the codebase.
So far, it seems the fields under app/(Signing) are the fields that are displayed after the document is made and sent. But we want to get to the fields as they are being added to the document to restrict their size.

I hope this makes sense and I'd appreciate some help on this

<!-- gh-comment-id:1929404917 --> @FatumaA commented on GitHub (Feb 6, 2024): Hi @dephraiim, I took a look here and I'm stuck on actually finding the right part of the codebase. So far, it seems the fields under app/(Signing) are the fields that are displayed after the document is made and sent. But we want to get to the fields as they are being added to the document to restrict their size. I hope this makes sense and I'd appreciate some help on this
Author
Owner

@sokhuong-uon commented on GitHub (Apr 1, 2024):

I see these lines trying to use minWidth and minHeight.
github.com/documenso/documenso@cbe6270494/packages/ui/primitives/document-flow/field-item.tsx (L100-L101)
Is there any problem with using fixed pixel values for minWidth and minHeight?

minHeight={'20px'}
minWidth={'60px'}

I tried zooming the document and didn't face any issues tho.

<!-- gh-comment-id:2029566491 --> @sokhuong-uon commented on GitHub (Apr 1, 2024): I see these lines trying to use minWidth and minHeight. https://github.com/documenso/documenso/blob/cbe62704940ee0877f62a417c078db855c9c9fe7/packages/ui/primitives/document-flow/field-item.tsx#L100-L101 Is there any problem with using fixed pixel values for minWidth and minHeight? ```ts minHeight={'20px'} minWidth={'60px'} ``` I tried zooming the document and didn't face any issues tho.
Author
Owner

@hkrhemendra commented on GitHub (Jul 2, 2024):

Hi, I am looking for my first contribution to open source.
Can I pick this issue?

<!-- gh-comment-id:2203644462 --> @hkrhemendra commented on GitHub (Jul 2, 2024): Hi, I am looking for my first contribution to open source. Can I pick this issue?
Author
Owner

@FatumaA commented on GitHub (Jul 2, 2024):

Should be fine if it's still an issue, right @ephraimduncan?

<!-- gh-comment-id:2203718362 --> @FatumaA commented on GitHub (Jul 2, 2024): Should be fine if it's still an issue, right @ephraimduncan?
Author
Owner

@ephraimduncan commented on GitHub (Jul 3, 2024):

Hi @hkrhemendra, I'm going to assign this to you

<!-- gh-comment-id:2205422786 --> @ephraimduncan commented on GitHub (Jul 3, 2024): Hi @hkrhemendra, I'm going to assign this to you
Author
Owner

@hkrhemendra commented on GitHub (Jul 3, 2024):

Hi @ephraimduncan @FatumaA, I have checked the signature field and I am not facing any issue.
Can you share me a screenshot? So, that I can check at the correction location of issue.
I am attaching the screenshot where I have checked the issue.

Screenshot 2024-07-03 at 8 50 19 PM

<!-- gh-comment-id:2206523900 --> @hkrhemendra commented on GitHub (Jul 3, 2024): Hi @ephraimduncan @FatumaA, I have checked the signature field and I am not facing any issue. Can you share me a screenshot? So, that I can check at the correction location of issue. I am attaching the screenshot where I have checked the issue. ![Screenshot 2024-07-03 at 8 50 19 PM](https://github.com/documenso/documenso/assets/51264979/029f9cb8-761e-4c09-beab-2ae014f9b2b3)
Author
Owner

@apsinghdev commented on GitHub (Aug 20, 2024):

hey @ephraimduncan I found this issue is yet to be fixed. can I work on this issue?

<!-- gh-comment-id:2298869861 --> @apsinghdev commented on GitHub (Aug 20, 2024): hey @ephraimduncan I found this issue is yet to be fixed. can I work on this issue?
Author
Owner

@asxzy commented on GitHub (Aug 29, 2024):

The field size is fixed and can be very annoying to show in a document.
image

<!-- gh-comment-id:2318983861 --> @asxzy commented on GitHub (Aug 29, 2024): The field size is fixed and can be very annoying to show in a document. <img width="538" alt="image" src="https://github.com/user-attachments/assets/adfe7b7e-8598-4193-b052-ff43b1ecbc17">
Author
Owner

@ElTimuro commented on GitHub (Sep 5, 2024):

  • @asxzy we already have plans to address this and will post updates here.
  • The plan is to let it scale linearly and not limiting the content, just will take a bit to do right
<!-- gh-comment-id:2331540069 --> @ElTimuro commented on GitHub (Sep 5, 2024): - @asxzy we already have plans to address this and will post updates here. - The plan is to let it scale linearly and not limiting the content, just will take a bit to do right
Author
Owner

@apsinghdev commented on GitHub (Sep 6, 2024):

@ElTimuro To my knowledge, there are a total of 10 fields, I guess, applying the idea of field sizing won't be suitable for some fields like Radio, Checkbox, Dropdown, Date, so do you have an explicit list of the one's that need this functionality? Please feel free to correct me if I'm wrong.

<!-- gh-comment-id:2333598592 --> @apsinghdev commented on GitHub (Sep 6, 2024): @ElTimuro To my knowledge, there are a total of 10 fields, I guess, applying the idea of field sizing won't be suitable for some fields like `Radio`, `Checkbox`, `Dropdown`, `Date`, so do you have an explicit list of the one's that need this functionality? Please feel free to correct me if I'm wrong.
Author
Owner

@rohitmore07 commented on GitHub (Feb 13, 2025):

Hey @ephraimduncan, I am very keen to work on this issue . I would be really happy if you could assign this issue to me.

<!-- gh-comment-id:2656883852 --> @rohitmore07 commented on GitHub (Feb 13, 2025): Hey @ephraimduncan, I am very keen to work on this issue . I would be really happy if you could assign this issue to me.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#268
No description provided.