starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[GH-ISSUE #829] Ctrl+K doesn't prevent default browser shortcut from executing #255

New issue

Closed

opened 2026-02-26 18:46:08 +03:00 by kerem · 8 comments

kerem commented

2026-02-26 18:46:08 +03:00

Owner

Originally created by @thisislvca on GitHub (Jan 12, 2024).
Original GitHub issue: https://github.com/documenso/documenso/issues/829

Issue Description

The Ctrl+K command on documenso opens the command popup, but also triggers the browser's shortcut correspondent to the same keybindings - which on Chrome by default pulls up the search function on the navigation bar.

In other websites with a similar command popup (such as Vercel) this doesn't happen.

Steps to Reproduce

Open the documenso app and press Ctrl+K.

Expected Behavior

The command popup opens without triggering Chrome's shortcut

Current Behavior

The command popup opens and triggers Chrome's shortcut, which in my case is quick search.

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

Ubuntu 22.04.3 LTS

Browser [e.g., Chrome, Firefox]

Chrome

Version [e.g., 2.0.1]

120.0.6099.216 (Official Build) (64-bit)

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @thisislvca on GitHub (Jan 12, 2024). Original GitHub issue: https://github.com/documenso/documenso/issues/829 ### Issue Description The Ctrl+K command on documenso opens the command popup, but also triggers the browser's shortcut correspondent to the same keybindings - which on Chrome by default pulls up the search function on the navigation bar. In other websites with a similar command popup (such as Vercel) this doesn't happen. ### Steps to Reproduce [Open the documenso app](https://app.documenso.com) and press Ctrl+K. ### Expected Behavior The command popup opens without triggering Chrome's shortcut ### Current Behavior The command popup opens and triggers Chrome's shortcut, which in my case is quick search. ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] Ubuntu 22.04.3 LTS ### Browser [e.g., Chrome, Firefox] Chrome ### Version [e.g., 2.0.1] 120.0.6099.216 (Official Build) (64-bit) ### Please check the boxes that apply to this issue report. - [X] I have searched the existing issues to make sure this is not a duplicate. - [X] I have provided steps to reproduce the issue. - [X] I have included relevant environment information. - [X] I have included any relevant screenshots. - [X] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [ ] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:46:08 +03:00

closed this issue
added the
type: bug
label

kerem commented

2026-02-26 18:46:09 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Jan 12, 2024):

Thank you for opening your first issue and for being a part of the open signing revolution!

One of our team members will review it and get back to you as soon as it possible 💚

Meanwhile, please feel free to hop into our community in Discord

@github-actions[bot] commented on GitHub (Jan 12, 2024): Thank you for opening your first issue and for being a part of the open signing revolution! <br /> One of our team members will review it and get back to you as soon as it possible 💚 <br /> Meanwhile, please feel free to hop into our community in [Discord](https://documen.so/discord)

kerem commented

2026-02-26 18:46:09 +03:00

Author

Owner

@ameeetgaikwad commented on GitHub (Jan 12, 2024):

I would like to contribute! Please assign me.

@ameeetgaikwad commented on GitHub (Jan 12, 2024): I would like to contribute! Please assign me.

kerem commented

2026-02-26 18:46:09 +03:00

Author

Owner

@aditya-chakraborty commented on GitHub (Jan 12, 2024):

I would like to contribute to Documenso! Please assign this to me if possible.

@aditya-chakraborty commented on GitHub (Jan 12, 2024): I would like to contribute to Documenso! Please assign this to me if possible.

kerem commented

2026-02-26 18:46:09 +03:00

Author

Owner

@thisislvca commented on GitHub (Jan 12, 2024):

@ameeetgaikwad @aditya-chakraborty I think the best way to contribute is to just open a PR that solves the issue! I'd do it myself but don't have much time rn haha

@thisislvca commented on GitHub (Jan 12, 2024): @ameeetgaikwad @aditya-chakraborty I think the best way to contribute is to just open a PR that solves the issue! I'd do it myself but don't have much time rn haha

kerem commented

2026-02-26 18:46:09 +03:00

Author

Owner

@dguyen commented on GitHub (Jan 14, 2024):

I just tested on Chrome/FireFox on Windows10/MacOS but couldn't replicate this.

Is this an Ubuntu only issue? Can someone else test to check?

@dguyen commented on GitHub (Jan 14, 2024): I just tested on Chrome/FireFox on Windows10/MacOS but couldn't replicate this. Is this an Ubuntu only issue? Can someone else test to check?

kerem commented

2026-02-26 18:46:09 +03:00

Author

Owner

@dguyen commented on GitHub (Jan 14, 2024):

We also currently have guidelines for taking issues:

https://github.com/documenso/documenso/blob/main/CONTRIBUTING.md#taking-issues

@dguyen commented on GitHub (Jan 14, 2024): We also currently have guidelines for taking issues: https://github.com/documenso/documenso/blob/main/CONTRIBUTING.md#taking-issues

kerem commented

2026-02-26 18:46:09 +03:00

Author

Owner

@thisislvca commented on GitHub (Jan 15, 2024):

Bug is present on firefox and chrome. Strange thing is that documenso is the only website with this strange behavior...

@thisislvca commented on GitHub (Jan 15, 2024): Bug is present on firefox and chrome. Strange thing is that documenso is the only website with this strange behavior...

kerem commented

2026-02-26 18:46:09 +03:00

Author

Owner

@Mythie commented on GitHub (Jan 16, 2024):

Apologies for the mis-step on my behalf here, I hadn't realised that it hadn't been assigned when approving and merging the associated PR. I'll try to do better 😓

@Mythie commented on GitHub (Jan 16, 2024): Apologies for the mis-step on my behalf here, I hadn't realised that it hadn't been assigned when approving and merging the associated PR. I'll try to do better 😓

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#255

No description provided.

Rows
Columns