starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-24 21:36:01 +03:00

[PR #2535] fix(i18n): add pluralization to expiration period picker #2373

New issue

Open

opened 2026-02-26 20:33:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2535
Author: @mKoonrad
Created: 2/24/2026
Status: 🔄 Open

Base: main ← Head: expiration-period-picker-plural

📝 Commits (1)

12b7af8 fix(i18n): add pluralization to expiration period picker

📊 Changes

1 file changed (+13 additions, -21 deletions)

View changed files

📝 packages/ui/components/document/expiration-period-picker.tsx (+13 -21)

📄 Description

Description

I added pluralization to expiration period picker.

Before:

After:
Zrzut ekranu 2026-02-24 173640
Zrzut ekranu 2026-02-24 173648

Changes Made

Add pluralization

Testing Performed

npm run build
Check web.po file

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2535 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 2/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `expiration-period-picker-plural` --- ### 📝 Commits (1) - [`12b7af8`](https://github.com/documenso/documenso/commit/12b7af8dcb009aa8693cb5568039885cafaa6d5e) fix(i18n): add pluralization to expiration period picker ### 📊 Changes **1 file changed** (+13 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/components/document/expiration-period-picker.tsx` (+13 -21) </details> ### 📄 Description ## Description I added pluralization to expiration period picker. Before: <img width="1125" height="438" alt="image" src="https://github.com/user-attachments/assets/03c7db15-8f73-4e6d-9cb8-8c44d4619b5a" /> After: <img width="591" height="451" alt="Zrzut ekranu 2026-02-24 173640" src="https://github.com/user-attachments/assets/6b92fb89-b99e-476b-967f-dd73cdca9a96" /> <img width="466" height="443" alt="Zrzut ekranu 2026-02-24 173648" src="https://github.com/user-attachments/assets/964aac1a-b8c0-47a2-bb8b-8e0607199458" /> ## Changes Made - Add pluralization ## Testing Performed - `npm run build` - Check `web.po` file ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-26 20:33:35 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2373

No description provided.

Rows
Columns